Alex Crichton 4032b7a429 std: Synchronize access to global env during exec ...

This commit, after reverting #55359, applies a different fix for #46775
while also fixing #55775. The basic idea was to go back to pre-#55359
libstd, and then fix #46775 in a way that doesn't expose #55775.

The issue described in #46775 boils down to two problems:

* First, the global environment is reset during `exec` but, but if the
  `exec` call fails then the global environment was a dangling pointer
  into free'd memory as the block of memory was deallocated when
  `Command` is dropped. This is fixed in this commit by installing a
  `Drop` stack object which ensures that the `environ` pointer is
  preserved on a failing `exec`.

* Second, the global environment was accessed in an unsynchronized
  fashion during `exec`. This was fixed by ensuring that the
  Rust-specific environment lock is acquired for these system-level
  operations.

Thanks to Alex Gaynor for pioneering the solution here!

Closes #55775

Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>

2018-11-14 12:46:57 -08:00

..

backtrace

std: stop backtracing when the frames are full

2018-08-16 11:28:42 -07:00

ext

Auto merge of #51553 - jD91mZM2:uds, r=sfackler

2018-07-11 14:15:01 +00:00

process

std: Synchronize access to global env during exec

2018-11-14 12:46:57 -08:00

alloc.rs

std: Delete the alloc_system crate

2018-11-11 09:22:28 -08:00

android.rs

Android: Fix unused-imports warning

2016-10-14 23:02:47 +02:00

args.rs

avoid using the word 'initialized' to talk about that non-reentrant-capable state of the mutex

2018-08-08 18:12:33 +02:00

cmath.rs

std: Move the cmath module into the sys module

2017-11-08 20:42:23 -08:00

condvar.rs

Fix coding style.

2018-07-31 09:49:10 +02:00

env.rs

Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.

2018-07-30 15:50:51 +02:00

fast_thread_local.rs

Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.

2018-07-30 15:50:51 +02:00

fd.rs

refactor: use shorthand fields

2018-11-06 15:05:44 -05:00

fs.rs

refactor: use shorthand fields

2018-11-06 15:05:44 -05:00

l4re.rs

Only link res_init() on GNU/*nix

2018-01-16 06:30:44 +11:00

memchr.rs

Move rust memchr impl to libcore

2017-12-13 01:15:18 -06:00

mod.rs

std: Delete the alloc_system crate

2018-11-11 09:22:28 -08:00

mutex.rs

Auto merge of #53108 - RalfJung:mutex, r=alexcrichton

2018-08-09 07:30:14 +00:00

net.rs

fix a typo: taget_env -> target_env

2018-08-27 14:58:14 -04:00

os_str.rs

Move Utf8Lossy decoder to libcore

2018-04-12 00:13:43 +02:00

os.rs

std: Synchronize access to global env during exec

2018-11-14 12:46:57 -08:00

path.rs

std: Move platform specific path code into sys

2016-10-01 19:28:17 +00:00

pipe.rs

read2: Use inner function instead of closure

2018-05-14 03:23:32 +02:00

rand.rs

Fix an endless loop when getrandom is not available

2018-09-02 00:19:11 +02:00

rwlock.rs

Fix typos in unix/rwlock.rs

2016-08-19 21:12:36 -04:00

stack_overflow.rs

Use a range to identify SIGSEGV in stack guards

2018-01-31 11:41:29 -08:00

stdio.rs

std: Minimize size of panicking on wasm

2018-04-13 07:03:00 -07:00

thread_local.rs

std: Avoid locks during TLS destruction on Windows

2017-05-05 06:59:49 -07:00

thread.rs

Add targets for HermitCore (https://hermitcore.org) to the Rust compiler and port libstd to it.

2018-07-30 15:50:51 +02:00

time.rs

refactor: use shorthand fields

2018-11-06 15:05:44 -05:00

weak.rs

use field init shorthand EVERYWHERE

2017-08-15 15:29:17 -07:00