Esteban Küber 7dfc3e9af4 Rework borrowing suggestions to use Expr instead of just Span ...

In the suggestion machinery for borrowing expressions and types, always use the available obligation `Span` to find the appropriate `Expr` to perform appropriateness checks no the `ExprKind` instead of on the textual snippet corresponding to the `Span`.

Unify the logic for the case where `&` *and* `&mut` are appropriate with the logic for only one of those cases.

Handle the case when `S::foo()` should have been `<&S>::foo()` (instead of suggesting the prior `&S::foo()`.

2025-07-10 17:23:29 +00:00

..

auxiliary

…

extern_fat_drop.rs

…

extern-1.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

extern-C-non-FFI-safe-arg-ice-52334.rs

Remove the -test suffix from normalize directives

2024-12-27 19:58:16 +11:00

extern-C-non-FFI-safe-arg-ice-52334.stderr

Revert #131669 due to ICEs

2024-12-09 17:31:16 +08:00

extern-C-str-arg-ice-80125.rs

…

extern-C-str-arg-ice-80125.stderr

Revert #131669 due to ICEs

2024-12-09 17:31:16 +08:00

extern-calling-convention-test.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

extern-compare-with-return-type.rs

Allow fn pointers comparisons lint in UI tests

2024-12-02 18:43:37 +01:00

extern-const.fixed

…

extern-const.rs

…

extern-const.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

extern-crate-multiple-missing.rs

…

extern-crate-multiple-missing.stderr

…

extern-crate-rename.rs

…

extern-crate-rename.stderr

More sophisticated span trimming

2025-02-21 00:41:17 +00:00

extern-crate-visibility.rs

…

extern-crate-visibility.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

extern-empty-string-issue-140884.rs

Avoid creating an empty identifer in Symbol::to_ident_string.

2025-05-21 18:59:04 +10:00

extern-empty-string-issue-140884.stderr

Avoid creating an empty identifer in Symbol::to_ident_string.

2025-05-21 18:59:04 +10:00

extern-ffi-fn-with-body.rs

…

extern-ffi-fn-with-body.stderr

…

extern-foreign-crate.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

extern-macro.rs

…

extern-macro.stderr

…

extern-main-fn.rs

…

extern-main-fn.stderr

…

extern-main-issue-86110.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

extern-main-issue-86110.stderr

…

extern-methods.rs

…

extern-mod-abi.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

extern-mod-ordering-exe.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

extern-no-mangle.rs

…

extern-no-mangle.stderr

…

extern-prelude-core.rs

remove support for the #[start] attribute

2025-01-21 06:59:15 -07:00

extern-prelude-no-speculative.rs

…

extern-prelude-std.rs

…

extern-pub.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

extern-rust.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

extern-static-size-overflow.rs

…

extern-static-size-overflow.stderr

TL note: current means target

2024-09-20 10:02:14 -07:00

extern-take-value.rs

Allow fn pointers comparisons lint in UI tests

2024-12-02 18:43:37 +01:00

extern-thiscall.rs

…

extern-type-diag-not-similar.rs

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-type-diag-not-similar.stderr

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-types-distinct-types.rs

…

extern-types-distinct-types.stderr

…

extern-types-field-offset.rs

Remove the -test suffix from normalize directives

2024-12-27 19:58:16 +11:00

extern-types-field-offset.run.stderr

Try to write the panic message with a single write_all call

2025-01-01 15:58:29 +01:00

extern-types-inherent-impl.rs

…

extern-types-manual-sync-send.rs

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-types-not-sync-send.rs

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-types-not-sync-send.stderr

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-types-pointer-cast.rs

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-types-size_of_val.align.run.stderr

Try to write the panic message with a single write_all call

2025-01-01 15:58:29 +01:00

extern-types-size_of_val.rs

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-types-size_of_val.size.run.stderr

Try to write the panic message with a single write_all call

2025-01-01 15:58:29 +01:00

extern-types-size_of_val.stderr

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-types-thin-pointer.rs

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-types-trait-impl.rs

tests: PointeeSized bounds with extern types

2025-06-16 23:04:35 +00:00

extern-types-unsized.rs

trait_sel: skip elaboration of sizedness supertrait

2025-06-16 23:04:36 +00:00

extern-types-unsized.stderr

trait_sel: skip elaboration of sizedness supertrait

2025-06-16 23:04:36 +00:00

extern-vectorcall.rs

vectorcall ABI: error if sse2 is not available

2025-02-20 12:40:58 +01:00

extern-wrong-value-type.rs

…

extern-wrong-value-type.stderr

…

fictional-abi.rs

compiler: gate extern "{abi}" in ast_lowering

2025-02-09 20:36:59 -08:00

fictional-abi.stderr

compiler: gate extern "{abi}" in ast_lowering

2025-02-09 20:36:59 -08:00

issue-1251.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

issue-10025.rs

Update tests.

2025-01-07 16:04:14 +01:00

issue-10763.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

issue-10764-rpass.rs

tests: remove //@ pretty-expanded usages

2024-11-26 02:50:48 +08:00

issue-13655.rs

…

issue-16250.rs

…

issue-16250.stderr

…

issue-18576.rs

tests: use needs-subprocess instead of ignore-{wasm32,emscripten,sgx}

2025-01-23 20:51:29 +08:00

issue-18819.rs

…

issue-18819.stderr

Show diff suggestion format on verbose replacement

2025-02-10 20:21:39 +00:00

issue-28324.rs

Use the informative error as the main const eval error message

2025-06-02 15:37:15 +00:00

issue-28324.stderr

const-eval error: always say in which item the error occurred

2025-06-07 13:42:30 +02:00

issue-36122-accessing-externed-dst.rs

…

issue-36122-accessing-externed-dst.stderr

Don't look at static items' HIR for wfcheck

2025-06-30 08:45:43 +00:00

issue-47725.rs

Fix duplicate help on export_name and others

2025-07-01 16:10:07 +02:00

issue-47725.stderr

Fix duplicate help on export_name and others

2025-07-01 16:10:07 +02:00

issue-64655-allow-unwind-when-calling-panic-directly.rs

tests: use needs-threads instead of ignore-emscripten

2025-01-23 20:51:29 +08:00

issue-64655-extern-rust-must-allow-unwind.rs

tests: use needs-threads instead of ignore-emscripten

2025-01-23 20:51:29 +08:00

issue-80074.rs

…

issue-80074.stderr

…

issue-95829.rs

Update tests.

2025-01-07 16:04:14 +01:00

issue-95829.stderr

Update tests.

2025-01-07 16:04:14 +01:00

issue-112363-extern-item-where-clauses-debug-ice.rs

UI tests: add missing diagnostic kinds where possible

2025-04-08 23:06:31 +03:00

issue-112363-extern-item-where-clauses-debug-ice.stderr

…

issue-116203.rs

…

issue-116203.stderr

Tweak multispan rendering

2024-12-12 23:36:27 +00:00

no-mangle-associated-fn.rs

…

no-mangle-associated-fn.stderr

…

not-in-block.rs

Update tests.

2025-01-07 16:04:14 +01:00

not-in-block.stderr

Trim suggestion parts to the subset that is purely additive

2025-02-14 00:44:10 -08:00

unsized-extern-derefmove.rs

tests: bless remaining tests

2025-06-16 23:04:35 +00:00

unsized-extern-derefmove.stderr

Rework borrowing suggestions to use Expr instead of just Span

2025-07-10 17:23:29 +00:00