2ab8480605
This subsumes the suggestions to borrow arguments with `AsRef`/`Borrow` bounds and those to borrow arguments with `Fn` and `FnMut` bounds. It works for other traits implemented on references as well, such as `std::io::Read`, `std::io::Write`, and `core::fmt::Write`. Incidentally, by making the logic for suggesting borrowing closures general, this removes some spurious suggestions to mutably borrow `FnMut` closures in assignments, as well as an unhelpful suggestion to add a `Clone` constraint to an `impl Fn` argument.
37 lines
726 B
Rust
37 lines
726 B
Rust
fn takes_fn(f: impl Fn()) {
|
|
loop {
|
|
takes_fnonce(f);
|
|
//~^ ERROR use of moved value
|
|
//~| HELP consider borrowing
|
|
}
|
|
}
|
|
|
|
fn takes_fn_mut(m: impl FnMut()) { //~ HELP if `impl FnMut()` implemented `Clone`
|
|
if maybe() {
|
|
takes_fnonce(m);
|
|
//~^ HELP consider mutably borrowing
|
|
}
|
|
takes_fnonce(m);
|
|
//~^ ERROR use of moved value
|
|
}
|
|
|
|
fn has_closure() {
|
|
let mut x = 0;
|
|
let mut closure = || {
|
|
x += 1;
|
|
};
|
|
takes_fnonce(closure);
|
|
//~^ HELP consider mutably borrowing
|
|
closure();
|
|
//~^ ERROR borrow of moved value
|
|
}
|
|
|
|
fn maybe() -> bool {
|
|
false
|
|
}
|
|
|
|
// Could also be Fn[Mut], here it doesn't matter
|
|
fn takes_fnonce(_: impl FnOnce()) {}
|
|
|
|
fn main() {}
|