Matthias Krüger
731ce84d19
Rollup merge of #138462 - ShE3py:mut-borrow-in-loop, r=oli-obk
...
Dedup `&mut *` reborrow suggestion in loops
#73534 added a reborrow suggestion in loops; #127579 generalized this to generic parameters, making the suggestion triggers twice:
```rs
use std::io::Read;
fn decode_scalar(_reader: impl Read) {}
fn decode_array(reader: &mut impl Read) {
for _ in 0.. {
decode_scalar(reader);
}
}
```
```
error[E0382]: use of moved value: `reader`
--> src/lib.rs:6:23
|
4 | fn decode_array(reader: &mut impl Read) {
| ------ move occurs because `reader` has type `&mut impl Read`, which does not implement the `Copy` trait
5 | for _ in 0.. {
| ------------ inside of this loop
6 | decode_scalar(reader);
| ^^^^^^ value moved here, in previous iteration of loop
|
help: consider creating a fresh reborrow of `reader` here
|
6 | decode_scalar(&mut *reader);
| ++++++
help: consider creating a fresh reborrow of `reader` here
|
6 | decode_scalar(&mut *reader);
| ++++++
```
This PR removes the suggestion in loops, as it requires generic parameters anyway (i.e., the reborrow is automatic if there is no generic params).
`@rustbot` label +A-borrow-checker +A-diagnostics +A-suggestion-diagnostics +D-papercut
2025-04-03 21:18:29 +02:00
..
2025-02-15 21:49:53 +00:00
2023-11-24 19:15:52 +01:00
2023-12-04 21:54:34 +00:00
2023-12-04 21:54:34 +00:00
2025-02-01 14:39:43 -07:00
2025-02-10 20:21:39 +00:00
2023-11-24 19:15:52 +01:00
2024-02-13 10:44:54 +00:00
2024-04-06 16:23:10 +00:00
2025-01-18 22:09:35 +00:00
2024-12-08 15:32:04 +08:00
2024-12-08 15:32:04 +08:00
2024-12-08 15:32:04 +08:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2025-02-20 03:37:19 +00:00
2025-02-20 03:37:19 +00:00
2023-04-21 22:32:38 +00:00
2023-11-24 19:15:52 +01:00
2024-08-18 19:46:53 +02:00
2024-08-18 19:46:53 +02:00
2024-08-18 19:46:53 +02:00
2024-08-18 19:46:53 +02:00
2024-08-18 19:46:53 +02:00
2024-08-18 19:46:53 +02:00
2024-08-18 19:46:53 +02:00
2024-08-18 19:46:53 +02:00
2024-07-26 14:41:56 -04:00
2024-09-13 14:10:56 +03:00
2024-09-13 14:10:56 +03:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-01-15 19:46:20 +00:00
2023-07-10 20:09:26 +00:00
2023-01-15 19:46:20 +00:00
2023-05-05 22:40:05 +12:00
2023-01-15 19:46:20 +00:00
2023-11-24 19:15:52 +01:00
2024-11-26 02:50:48 +08:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-07-26 14:41:56 -04:00
2024-02-16 20:02:50 +00:00
2023-04-17 09:16:07 +02:00
2024-04-10 20:36:14 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-05-05 22:40:05 +12:00
2023-11-24 19:15:52 +01:00
2024-11-26 02:50:48 +08:00
2023-07-10 20:09:26 +00:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2023-01-15 19:46:20 +00:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-04-12 04:46:31 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2024-07-04 05:36:34 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2025-01-27 23:42:47 +00:00
2025-01-27 23:42:47 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-11-26 02:50:48 +08:00
2024-07-26 14:41:56 -04:00
2024-02-16 20:02:50 +00:00
2024-04-11 16:41:41 +00:00
2024-04-11 16:41:41 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-04-11 16:41:41 +00:00
2024-04-11 16:41:41 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2024-04-15 21:36:52 -04:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2023-07-10 20:09:26 +00:00
2023-11-24 19:15:52 +01:00
2024-04-11 16:41:41 +00:00
2024-02-16 20:02:50 +00:00
2024-04-11 16:41:41 +00:00
2023-05-05 22:40:04 +12:00
2024-07-26 14:41:56 -04:00
2024-11-26 02:50:48 +08:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-07-26 14:41:56 -04:00
2024-07-26 14:41:56 -04:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-07-10 20:09:26 +00:00
2023-07-10 20:09:26 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2025-01-23 20:51:29 +08:00
2024-02-16 20:02:50 +00:00
2023-01-15 19:46:20 +00:00
2024-07-04 02:02:21 +00:00
2024-02-16 20:02:50 +00:00
2024-04-24 22:21:16 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-07-26 14:41:56 -04:00
2024-06-29 19:58:18 +08:00
2023-11-24 19:15:52 +01:00
2024-07-26 14:41:56 -04:00
2023-10-24 15:30:17 +00:00
2023-10-24 15:30:17 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-10-24 15:30:17 +00:00
2023-10-24 15:30:17 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-04-11 16:41:41 +00:00
2024-02-16 20:02:50 +00:00
2024-04-11 16:41:41 +00:00
2024-04-11 16:41:41 +00:00
2024-04-11 16:41:41 +00:00
2024-04-24 22:21:15 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2024-07-26 14:41:56 -04:00
2024-02-16 20:02:50 +00:00
2024-07-26 14:41:56 -04:00
2023-11-24 19:15:52 +01:00
2023-07-10 20:09:26 +00:00
2023-07-10 20:09:26 +00:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-07-10 20:09:26 +00:00
2023-11-24 19:15:52 +01:00
2024-04-24 22:21:15 +00:00
2023-11-24 19:15:52 +01:00
2023-07-10 20:09:26 +00:00
2024-04-11 16:41:41 +00:00
2024-07-26 14:41:56 -04:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2023-05-05 22:40:05 +12:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2025-03-30 01:32:21 +03:00
2025-03-30 01:32:21 +03:00
2023-11-24 19:15:52 +01:00
2024-04-10 20:36:14 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-11-26 02:50:48 +08:00
2024-04-10 20:36:14 +00:00
2024-04-11 16:41:42 +00:00
2025-02-21 00:41:17 +00:00
2023-11-24 19:15:52 +01:00
2025-02-04 10:57:49 +00:00
2024-11-26 02:50:48 +08:00
2024-07-26 14:41:56 -04:00
2024-04-11 16:41:42 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2024-04-15 21:36:52 -04:00
2024-02-06 23:12:23 +00:00
2024-04-10 20:36:14 +00:00
2023-11-24 19:15:52 +01:00
2023-01-15 19:46:20 +00:00
2023-11-24 19:15:52 +01:00
2023-07-10 20:09:26 +00:00
2024-11-26 02:50:48 +08:00
2024-02-16 20:02:50 +00:00
2024-02-18 06:01:40 +03:00
2025-02-21 00:41:17 +00:00
2024-02-16 20:02:50 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2024-11-26 02:50:48 +08:00
2023-01-15 19:46:20 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2024-04-10 20:36:14 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-04-11 16:41:41 +00:00
2024-04-11 16:41:41 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-04-11 16:41:41 +00:00
2024-03-13 23:05:11 +00:00
2024-12-07 21:37:13 +00:00
2024-04-11 16:41:41 +00:00
2024-02-16 20:02:50 +00:00
2024-04-11 16:41:41 +00:00
2024-03-23 20:22:51 +01:00
2024-06-27 15:19:08 -04:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2024-07-16 02:48:47 +08:00
2024-07-16 02:48:47 +08:00
2023-11-24 19:15:52 +01:00
2023-03-05 16:56:57 +01:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-01-16 09:25:28 +01:00
2024-02-16 20:02:50 +00:00
2025-01-06 16:08:29 -08:00
2024-02-16 20:02:50 +00:00
2024-05-29 09:27:07 +00:00
2024-05-29 09:27:07 +00:00
2024-03-21 21:27:37 +01:00
2024-03-21 21:27:37 +01:00
2024-07-24 23:36:47 -04:00
2024-07-24 23:36:47 -04:00
2024-07-04 02:02:21 +00:00
2024-12-21 19:08:30 +00:00
2025-01-06 16:08:29 -08:00
2025-02-11 19:24:07 +00:00
2025-02-11 19:24:07 +00:00
2023-11-24 19:15:52 +01:00
2025-02-10 20:21:39 +00:00
2025-01-06 16:08:29 -08:00
2025-01-06 16:08:29 -08:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2024-04-24 22:21:15 +00:00
2024-09-13 14:10:56 +03:00
2024-09-13 14:10:56 +03:00
2024-02-16 20:02:50 +00:00
2024-04-10 20:36:14 +00:00
2023-11-24 19:15:52 +01:00
2025-01-23 20:51:29 +08:00
2024-02-16 20:02:50 +00:00
2024-07-04 04:36:52 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-07-04 02:02:21 +00:00
2024-07-04 02:02:21 +00:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-04-20 15:06:17 -03:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-09-13 14:10:56 +03:00
2024-09-13 14:10:56 +03:00
2024-02-16 20:02:50 +00:00
2023-03-03 16:33:11 +01:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-10-24 15:30:17 +00:00
2024-04-10 20:36:14 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2025-02-14 00:44:10 -08:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2025-02-14 00:44:10 -08:00
2024-12-23 22:15:32 +00:00
2024-12-23 22:15:32 +00:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2025-02-28 16:28:41 +00:00
2025-03-14 19:50:03 +00:00
2023-11-24 19:15:52 +01:00
2024-03-20 13:00:34 -04:00
2024-07-22 22:51:53 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-12-04 21:54:32 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2024-01-13 22:00:34 +00:00
2025-02-21 00:41:17 +00:00
2024-01-13 22:00:34 +00:00
2025-02-21 00:41:17 +00:00
2024-04-11 16:41:41 +00:00
2025-02-28 16:28:41 +00:00
2025-03-14 19:50:03 +00:00
2025-02-28 16:28:41 +00:00
2025-03-14 19:50:03 +00:00
2024-01-13 22:00:34 +00:00
2024-01-13 22:00:34 +00:00
2023-11-24 19:15:52 +01:00
2025-02-24 09:26:54 +00:00
2025-02-24 09:26:54 +00:00
2023-11-24 19:15:52 +01:00
2025-01-28 19:35:51 +00:00
2025-01-28 19:35:51 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-09-21 22:20:58 +02:00
2024-07-26 14:41:56 -04:00
2025-01-28 14:11:29 +00:00
2024-02-16 20:02:50 +00:00
2024-04-15 21:36:52 -04:00
2024-02-16 20:02:50 +00:00
2024-04-24 22:21:15 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-12-12 23:36:27 +00:00
2023-05-29 13:11:03 +08:00
2024-07-04 05:36:34 +00:00
2023-08-23 12:35:00 +08:00
2025-03-14 19:50:03 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2025-02-14 00:44:10 -08:00
2024-01-13 22:00:34 +00:00
2024-04-24 22:21:15 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-02-20 15:34:11 +01:00
2024-02-20 15:34:11 +01:00
2023-11-24 19:15:52 +01:00
2024-04-24 22:21:15 +00:00
2024-04-11 16:41:41 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-04-24 22:21:15 +00:00
2024-07-19 09:34:32 +08:00
2024-12-07 21:26:20 +00:00
2024-06-29 19:58:18 +08:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2024-04-24 22:21:15 +00:00
2024-07-17 10:07:02 +08:00
2024-07-17 10:07:02 +08:00
2024-07-17 10:07:02 +08:00
2024-03-17 21:32:26 +00:00
2025-03-13 18:03:26 +01:00
2023-07-10 20:09:26 +00:00
2025-03-30 01:32:21 +03:00
2023-07-10 20:09:26 +00:00
2024-07-04 05:36:34 +00:00
2024-12-13 16:32:23 +01:00
2025-02-10 20:21:39 +00:00
2024-04-21 22:00:38 +02:00
2024-04-21 22:00:38 +02:00
2024-03-23 12:19:05 +01:00
2024-03-23 12:19:05 +01:00
2025-03-11 12:05:02 +00:00
2025-03-11 12:05:02 +00:00
2023-11-24 19:15:52 +01:00
2024-08-22 02:20:05 +00:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-11-24 19:15:52 +01:00
2023-12-04 21:54:32 +00:00
2024-04-15 21:36:52 -04:00
2023-07-10 20:09:26 +00:00
2023-11-24 19:15:52 +01:00
2023-07-10 20:09:26 +00:00
2023-04-25 20:41:59 +00:00
2025-02-10 20:21:39 +00:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2024-04-25 04:54:25 +08:00
2024-07-04 02:02:21 +00:00
2023-11-24 19:15:52 +01:00
2023-04-30 23:57:47 +02:00
2024-07-04 02:02:21 +00:00
2024-04-06 16:23:10 +00:00
2025-01-28 19:35:51 +00:00
2023-11-24 19:15:52 +01:00
2024-05-09 14:47:09 +10:00
2024-05-09 14:47:09 +10:00
2024-05-09 14:47:09 +10:00
2024-05-09 14:47:09 +10:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-11-24 19:15:52 +01:00
2024-02-16 20:02:50 +00:00
2024-02-16 20:02:50 +00:00
2023-07-10 20:09:26 +00:00
2024-02-16 20:02:50 +00:00
2024-05-09 14:47:09 +10:00
2024-05-09 14:47:09 +10:00
2024-02-16 20:02:50 +00:00
2024-05-09 14:47:09 +10:00
2024-05-09 14:47:09 +10:00
2023-11-24 19:15:52 +01:00
2025-01-06 16:08:29 -08:00
2024-04-11 16:41:41 +00:00
2024-02-16 20:02:50 +00:00
2024-04-11 16:41:41 +00:00
2024-06-12 11:11:02 +08:00
2024-06-12 11:11:02 +08:00
2024-06-17 15:21:07 +10:00
2025-02-10 20:21:39 +00:00