rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
Files
51b51b51d7931da85280382a81c4dd80c73ca754
rust/tests/mir-opt/pre-codegen
History
bors 00095b3da4 Auto merge of #132527 - DianQK:gvn-stmt-iter, r=oli-obk 
gvn: Invalid dereferences for all non-local mutations

Fixes #132353.

This PR removes the computation value by traversing SSA locals through `for_each_assignment_mut`.

Because the `for_each_assignment_mut` traversal skips statements which have side effects, such as dereference assignments, the computation may be unsound. Instead of `for_each_assignment_mut`, we compute values by traversing in reverse postorder.

Because we compute and use the symbolic representation of values on the fly, I invalidate all old values when encountering a dereference assignment. The current approach does not prevent the optimization of a clone to a copy.

In the future, we may add an alias model, or dominance information for dereference assignments, or SSA form to help GVN.

r? cjgillot

cc `@jieyouxu` #132356
cc `@RalfJung` #133474
2025-04-03 19:17:33 +00:00
..
chained_comparison.bitand.PreCodegen.after.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
chained_comparison.naive.PreCodegen.after.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
chained_comparison.returning.PreCodegen.after.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
chained_comparison.rs
…
checked_ops.checked_shl.PreCodegen.after.panic-abort.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
checked_ops.checked_shl.PreCodegen.after.panic-unwind.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
checked_ops.rs
Add MIR pre-codegen tests to track 138544
2025-03-15 14:13:37 -07:00
checked_ops.saturating_sub_at_home.PreCodegen.after.panic-abort.mir
Add MIR pre-codegen tests to track 138544
2025-03-15 14:13:37 -07:00
checked_ops.saturating_sub_at_home.PreCodegen.after.panic-unwind.mir
Add MIR pre-codegen tests to track 138544
2025-03-15 14:13:37 -07:00
checked_ops.step_forward.PreCodegen.after.panic-abort.mir
Export likely(), unlikely() and cold_path() in std::hint
2025-01-15 21:42:47 +01:00
checked_ops.step_forward.PreCodegen.after.panic-unwind.mir
Export likely(), unlikely() and cold_path() in std::hint
2025-01-15 21:42:47 +01:00
checked_ops.use_checked_sub.PreCodegen.after.panic-abort.mir
Add MIR pre-codegen tests to track 138544
2025-03-15 14:13:37 -07:00
checked_ops.use_checked_sub.PreCodegen.after.panic-unwind.mir
Add MIR pre-codegen tests to track 138544
2025-03-15 14:13:37 -07:00
clone_as_copy.clone_as_copy.PreCodegen.after.mir
Simplify the canonical clone method to copy
2024-09-14 13:30:35 +08:00
clone_as_copy.enum_clone_as_copy.PreCodegen.after.mir
Simplify the canonical clone method to copy
2024-09-14 13:30:35 +08:00
clone_as_copy.rs
Remove unsound-mir-opts for simplify_aggregate_to_copy
2025-04-03 21:59:43 +08:00
deref_nested_borrows.rs
Revert "comment out the old tests instead of adjusting them"
2025-04-02 19:59:26 +08:00
deref_nested_borrows.src.GVN.panic-abort.diff
Do not unify dereferences in GVN.
2024-11-25 20:19:08 +01:00
deref_nested_borrows.src.GVN.panic-unwind.diff
Do not unify dereferences in GVN.
2024-11-25 20:19:08 +01:00
deref_nested_borrows.src.PreCodegen.after.panic-abort.mir
Do not unify dereferences in GVN.
2024-11-25 20:19:08 +01:00
deref_nested_borrows.src.PreCodegen.after.panic-unwind.mir
Do not unify dereferences in GVN.
2024-11-25 20:19:08 +01:00
derived_ord.{impl#0}-partial_cmp.PreCodegen.after.mir
Make is_le and friends work like clang's
2025-03-05 21:58:46 -08:00
derived_ord.demo_le.PreCodegen.after.mir
Make is_le and friends work like clang's
2025-03-05 21:58:46 -08:00
derived_ord.rs
Make is_le and friends work like clang's
2025-03-05 21:58:46 -08:00
duplicate_switch_targets.rs
…
duplicate_switch_targets.ub_if_b.PreCodegen.after.mir
…
intrinsics.f_u64.PreCodegen.after.mir
…
intrinsics.f_unit.PreCodegen.after.mir
…
intrinsics.rs
…
issue_117368_print_invalid_constant.main.GVN.32bit.panic-abort.diff
Update NonZero and NonNull to not field-project (per MCP807)
2024-12-03 11:13:34 -08:00
issue_117368_print_invalid_constant.main.GVN.32bit.panic-unwind.diff
Update NonZero and NonNull to not field-project (per MCP807)
2024-12-03 11:13:34 -08:00
issue_117368_print_invalid_constant.main.GVN.64bit.panic-abort.diff
Update NonZero and NonNull to not field-project (per MCP807)
2024-12-03 11:13:34 -08:00
issue_117368_print_invalid_constant.main.GVN.64bit.panic-unwind.diff
Update NonZero and NonNull to not field-project (per MCP807)
2024-12-03 11:13:34 -08:00
issue_117368_print_invalid_constant.rs
ignore/fix layout-sensitive tests
2024-08-31 23:56:45 +02:00
loops.filter_mapped.PreCodegen.after.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
loops.int_range.PreCodegen.after.mir
Allow more top-down inlining for single-BB callees
2025-03-12 22:39:43 -07:00
loops.mapped.PreCodegen.after.mir
Inline FnOnce once again
2025-03-03 23:30:18 +00:00
loops.rs
…
loops.vec_move.PreCodegen.after.mir
Perform instsimplify before inline to eliminate some trivial calls
2024-07-29 18:14:35 +08:00
matches_macro.issue_77355_opt.PreCodegen.after.mir
…
matches_macro.rs
…
mem_replace.manual_replace.PreCodegen.after.panic-abort.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
mem_replace.manual_replace.PreCodegen.after.panic-unwind.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
mem_replace.mem_replace.PreCodegen.after.panic-abort.mir
Allow more top-down inlining for single-BB callees
2025-03-12 22:39:43 -07:00
mem_replace.mem_replace.PreCodegen.after.panic-unwind.mir
Allow more top-down inlining for single-BB callees
2025-03-12 22:39:43 -07:00
mem_replace.rs
tests: ignore-debug -> ignore-std-debug-assertions
2024-10-31 17:33:42 +08:00
no_inlined_clone.{impl#0}-clone.PreCodegen.after.mir
Remove unsound-mir-opts for simplify_aggregate_to_copy
2025-04-03 21:59:43 +08:00
no_inlined_clone.rs
Perform instsimplify before inline to eliminate some trivial calls
2024-07-29 18:14:35 +08:00
optimizes_into_variable.main.GVN.32bit.panic-abort.diff
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
optimizes_into_variable.main.GVN.32bit.panic-unwind.diff
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
optimizes_into_variable.main.GVN.64bit.panic-abort.diff
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
optimizes_into_variable.main.GVN.64bit.panic-unwind.diff
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
optimizes_into_variable.main.PreCodegen.after.32bit.panic-abort.mir
…
optimizes_into_variable.main.PreCodegen.after.32bit.panic-unwind.mir
…
optimizes_into_variable.main.PreCodegen.after.64bit.panic-abort.mir
…
optimizes_into_variable.main.PreCodegen.after.64bit.panic-unwind.mir
…
optimizes_into_variable.main.ScalarReplacementOfAggregates.32bit.panic-abort.diff
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
optimizes_into_variable.main.ScalarReplacementOfAggregates.32bit.panic-unwind.diff
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
optimizes_into_variable.main.ScalarReplacementOfAggregates.64bit.panic-abort.diff
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
optimizes_into_variable.main.ScalarReplacementOfAggregates.64bit.panic-unwind.diff
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
optimizes_into_variable.main.SimplifyLocals-final.after.32bit.panic-abort.mir
…
optimizes_into_variable.main.SimplifyLocals-final.after.32bit.panic-unwind.mir
…
optimizes_into_variable.main.SimplifyLocals-final.after.64bit.panic-abort.mir
…
optimizes_into_variable.main.SimplifyLocals-final.after.64bit.panic-unwind.mir
…
optimizes_into_variable.rs
Use -Zdump-mir-exclude-alloc-bytes in some mir-opt tests
2024-06-26 15:05:01 -07:00
ptr_offset.demo_byte_add_fat.PreCodegen.after.panic-abort.mir
Bless mir-opt tests
2024-10-07 11:18:37 -04:00
ptr_offset.demo_byte_add_fat.PreCodegen.after.panic-unwind.mir
Bless mir-opt tests
2024-10-07 11:18:37 -04:00
ptr_offset.demo_byte_add_thin.PreCodegen.after.panic-abort.mir
Bless mir-opt tests
2024-10-07 11:18:37 -04:00
ptr_offset.demo_byte_add_thin.PreCodegen.after.panic-unwind.mir
Bless mir-opt tests
2024-10-07 11:18:37 -04:00
ptr_offset.rs
tests: ignore-debug -> ignore-std-debug-assertions
2024-10-31 17:33:42 +08:00
range_iter.forward_loop.PreCodegen.after.panic-abort.mir
Allow more top-down inlining for single-BB callees
2025-03-12 22:39:43 -07:00
range_iter.forward_loop.PreCodegen.after.panic-unwind.mir
Allow more top-down inlining for single-BB callees
2025-03-12 22:39:43 -07:00
range_iter.inclusive_loop.PreCodegen.after.panic-abort.mir
std::range
2025-01-30 20:37:56 -07:00
range_iter.inclusive_loop.PreCodegen.after.panic-unwind.mir
std::range
2025-01-30 20:37:56 -07:00
range_iter.range_inclusive_iter_next.PreCodegen.after.panic-abort.mir
std::range
2025-01-30 20:37:56 -07:00
range_iter.range_inclusive_iter_next.PreCodegen.after.panic-unwind.mir
std::range
2025-01-30 20:37:56 -07:00
range_iter.range_iter_next.PreCodegen.after.panic-abort.mir
Allow more top-down inlining for single-BB callees
2025-03-12 22:39:43 -07:00
range_iter.range_iter_next.PreCodegen.after.panic-unwind.mir
Allow more top-down inlining for single-BB callees
2025-03-12 22:39:43 -07:00
range_iter.rs
…
README.md
…
simple_option_map.ezmap.PreCodegen.after.mir
Add MIR pre-codegen tests to track 138544
2025-03-15 14:13:37 -07:00
simple_option_map.map_via_question_mark.PreCodegen.after.mir
Add MIR pre-codegen tests to track 138544
2025-03-15 14:13:37 -07:00
simple_option_map.rs
Add MIR pre-codegen tests to track 138544
2025-03-15 14:13:37 -07:00
slice_filter.rs
…
slice_filter.variant_a-{closure#0}.PreCodegen.after.mir
Bless tests
2025-04-02 19:59:26 +08:00
slice_filter.variant_b-{closure#0}.PreCodegen.after.mir
Bless tests
2025-04-02 19:59:26 +08:00
slice_index.rs
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
slice_index.slice_get_mut_usize.PreCodegen.after.panic-abort.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
slice_index.slice_get_mut_usize.PreCodegen.after.panic-unwind.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
slice_index.slice_get_unchecked_mut_range.PreCodegen.after.panic-abort.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
slice_index.slice_get_unchecked_mut_range.PreCodegen.after.panic-unwind.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
slice_index.slice_index_range.PreCodegen.after.panic-abort.mir
…
slice_index.slice_index_range.PreCodegen.after.panic-unwind.mir
…
slice_index.slice_index_usize.PreCodegen.after.panic-abort.mir
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
slice_index.slice_index_usize.PreCodegen.after.panic-unwind.mir
Reapply "Auto merge of #133734 - scottmcm:lower-indexing-to-ptrmetadata, r=davidtwco,RalfJung"
2025-01-27 23:42:47 +00:00
slice_index.slice_ptr_get_unchecked_range.PreCodegen.after.panic-abort.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
slice_index.slice_ptr_get_unchecked_range.PreCodegen.after.panic-unwind.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
slice_iter.enumerated_loop.PreCodegen.after.panic-abort.mir
Make slice iterator constructors unstably const
2025-04-02 10:39:14 -07:00
slice_iter.enumerated_loop.PreCodegen.after.panic-unwind.mir
Make slice iterator constructors unstably const
2025-04-02 10:39:14 -07:00
slice_iter.forward_loop.PreCodegen.after.panic-abort.mir
Make slice iterator constructors unstably const
2025-04-02 10:39:14 -07:00
slice_iter.forward_loop.PreCodegen.after.panic-unwind.mir
Make slice iterator constructors unstably const
2025-04-02 10:39:14 -07:00
slice_iter.range_loop.PreCodegen.after.panic-abort.mir
Allow more top-down inlining for single-BB callees
2025-03-12 22:39:43 -07:00
slice_iter.range_loop.PreCodegen.after.panic-unwind.mir
Allow more top-down inlining for single-BB callees
2025-03-12 22:39:43 -07:00
slice_iter.reverse_loop.PreCodegen.after.panic-abort.mir
Make slice iterator constructors unstably const
2025-04-02 10:39:14 -07:00
slice_iter.reverse_loop.PreCodegen.after.panic-unwind.mir
Make slice iterator constructors unstably const
2025-04-02 10:39:14 -07:00
slice_iter.rs
tests: ignore-debug -> ignore-std-debug-assertions
2024-10-31 17:33:42 +08:00
slice_iter.slice_iter_generic_is_empty.PreCodegen.after.panic-abort.mir
transmute should also assume non-null pointers
2025-02-12 23:01:27 -08:00
slice_iter.slice_iter_generic_is_empty.PreCodegen.after.panic-unwind.mir
transmute should also assume non-null pointers
2025-02-12 23:01:27 -08:00
slice_iter.slice_iter_mut_next_back.PreCodegen.after.panic-abort.mir
Avoid MIR bloat in inlining
2024-07-01 05:17:13 -07:00
slice_iter.slice_iter_mut_next_back.PreCodegen.after.panic-unwind.mir
Avoid MIR bloat in inlining
2024-07-01 05:17:13 -07:00
slice_iter.slice_iter_next.PreCodegen.after.panic-abort.mir
Go back to Some instead of transmuting to it.
2025-02-14 22:24:27 -08:00
slice_iter.slice_iter_next.PreCodegen.after.panic-unwind.mir
Go back to Some instead of transmuting to it.
2025-02-14 22:24:27 -08:00
spans.outer.PreCodegen.after.panic-abort.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
spans.outer.PreCodegen.after.panic-unwind.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
spans.rs
…
try_identity.new.PreCodegen.after.mir
Bless *all* the mir-opt tests
2024-08-18 16:07:33 -07:00
try_identity.old.PreCodegen.after.mir
Remove unsound-mir-opts for simplify_aggregate_to_copy
2025-04-03 21:59:43 +08:00
try_identity.rs
…
tuple_ord.demo_ge_partial.PreCodegen.after.mir
Stop using specialization for this
2025-03-23 15:27:31 -07:00
tuple_ord.demo_le_total.PreCodegen.after.mir
Stop using specialization for this
2025-03-23 15:27:31 -07:00
tuple_ord.rs
Add chaining versions of lt/le/gt/ge and use them in tuple PartialOrd
2025-03-19 09:27:02 -07:00
vec_deref.rs
…
vec_deref.vec_deref_to_slice.PreCodegen.after.panic-abort.mir
[mir-opt] GVN some more transmute cases
2025-01-08 18:46:30 -08:00
vec_deref.vec_deref_to_slice.PreCodegen.after.panic-unwind.mir
[mir-opt] GVN some more transmute cases
2025-01-08 18:46:30 -08:00

README.md

The goal of this directory is to track the quality of MIR that is given to codegen in a standard -O condiguration.

As such, feel free to --bless whatever changes you get here, so long as doing so doesn't add substantially more MIR.