764 lines
22 KiB
Plaintext
764 lines
22 KiB
Plaintext
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:83:13
|
|
|
|
|
LL | let _ = opt.unwrap_or_else(|| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
= note: `-D clippy::unnecessary-lazy-evaluations` implied by `-D warnings`
|
|
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_lazy_evaluations)]`
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = opt.unwrap_or_else(|| 2);
|
|
LL + let _ = opt.unwrap_or(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:85:13
|
|
|
|
|
LL | let _ = opt.unwrap_or_else(|| astronomers_pi);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = opt.unwrap_or_else(|| astronomers_pi);
|
|
LL + let _ = opt.unwrap_or(astronomers_pi);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:87:13
|
|
|
|
|
LL | let _ = opt.unwrap_or_else(|| ext_str.some_field);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = opt.unwrap_or_else(|| ext_str.some_field);
|
|
LL + let _ = opt.unwrap_or(ext_str.some_field);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:90:13
|
|
|
|
|
LL | let _ = opt.and_then(|_| ext_opt);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `and` instead
|
|
|
|
|
LL - let _ = opt.and_then(|_| ext_opt);
|
|
LL + let _ = opt.and(ext_opt);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:92:13
|
|
|
|
|
LL | let _ = opt.or_else(|| ext_opt);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _ = opt.or_else(|| ext_opt);
|
|
LL + let _ = opt.or(ext_opt);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:94:13
|
|
|
|
|
LL | let _ = opt.or_else(|| None);
|
|
| ^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _ = opt.or_else(|| None);
|
|
LL + let _ = opt.or(None);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:96:13
|
|
|
|
|
LL | let _ = opt.get_or_insert_with(|| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `get_or_insert` instead
|
|
|
|
|
LL - let _ = opt.get_or_insert_with(|| 2);
|
|
LL + let _ = opt.get_or_insert(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:98:13
|
|
|
|
|
LL | let _ = opt.ok_or_else(|| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `ok_or` instead
|
|
|
|
|
LL - let _ = opt.ok_or_else(|| 2);
|
|
LL + let _ = opt.ok_or(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:100:13
|
|
|
|
|
LL | let _ = nested_tuple_opt.unwrap_or_else(|| Some((1, 2)));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = nested_tuple_opt.unwrap_or_else(|| Some((1, 2)));
|
|
LL + let _ = nested_tuple_opt.unwrap_or(Some((1, 2)));
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:102:13
|
|
|
|
|
LL | let _ = cond.then(|| astronomers_pi);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _ = cond.then(|| astronomers_pi);
|
|
LL + let _ = cond.then_some(astronomers_pi);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:104:13
|
|
|
|
|
LL | let _ = true.then(|| -> _ {});
|
|
| ^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _ = true.then(|| -> _ {});
|
|
LL + let _ = true.then_some({});
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:106:13
|
|
|
|
|
LL | let _ = true.then(|| {});
|
|
| ^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _ = true.then(|| {});
|
|
LL + let _ = true.then_some({});
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:111:13
|
|
|
|
|
LL | let _ = Some(1).unwrap_or_else(|| *r);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = Some(1).unwrap_or_else(|| *r);
|
|
LL + let _ = Some(1).unwrap_or(*r);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:114:13
|
|
|
|
|
LL | let _ = Some(1).unwrap_or_else(|| *b);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = Some(1).unwrap_or_else(|| *b);
|
|
LL + let _ = Some(1).unwrap_or(*b);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:117:13
|
|
|
|
|
LL | let _ = Some(1).as_ref().unwrap_or_else(|| &r);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = Some(1).as_ref().unwrap_or_else(|| &r);
|
|
LL + let _ = Some(1).as_ref().unwrap_or(&r);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:119:13
|
|
|
|
|
LL | let _ = Some(1).as_ref().unwrap_or_else(|| &b);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = Some(1).as_ref().unwrap_or_else(|| &b);
|
|
LL + let _ = Some(1).as_ref().unwrap_or(&b);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:123:13
|
|
|
|
|
LL | let _ = Some(10).unwrap_or_else(|| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = Some(10).unwrap_or_else(|| 2);
|
|
LL + let _ = Some(10).unwrap_or(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:125:13
|
|
|
|
|
LL | let _ = Some(10).and_then(|_| ext_opt);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `and` instead
|
|
|
|
|
LL - let _ = Some(10).and_then(|_| ext_opt);
|
|
LL + let _ = Some(10).and(ext_opt);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:127:28
|
|
|
|
|
LL | let _: Option<usize> = None.or_else(|| ext_opt);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _: Option<usize> = None.or_else(|| ext_opt);
|
|
LL + let _: Option<usize> = None.or(ext_opt);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:129:13
|
|
|
|
|
LL | let _ = None.get_or_insert_with(|| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `get_or_insert` instead
|
|
|
|
|
LL - let _ = None.get_or_insert_with(|| 2);
|
|
LL + let _ = None.get_or_insert(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:131:35
|
|
|
|
|
LL | let _: Result<usize, usize> = None.ok_or_else(|| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `ok_or` instead
|
|
|
|
|
LL - let _: Result<usize, usize> = None.ok_or_else(|| 2);
|
|
LL + let _: Result<usize, usize> = None.ok_or(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:133:28
|
|
|
|
|
LL | let _: Option<usize> = None.or_else(|| None);
|
|
| ^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _: Option<usize> = None.or_else(|| None);
|
|
LL + let _: Option<usize> = None.or(None);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:137:13
|
|
|
|
|
LL | let _ = deep.0.unwrap_or_else(|| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = deep.0.unwrap_or_else(|| 2);
|
|
LL + let _ = deep.0.unwrap_or(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:139:13
|
|
|
|
|
LL | let _ = deep.0.and_then(|_| ext_opt);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `and` instead
|
|
|
|
|
LL - let _ = deep.0.and_then(|_| ext_opt);
|
|
LL + let _ = deep.0.and(ext_opt);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:141:13
|
|
|
|
|
LL | let _ = deep.0.or_else(|| None);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _ = deep.0.or_else(|| None);
|
|
LL + let _ = deep.0.or(None);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:143:13
|
|
|
|
|
LL | let _ = deep.0.get_or_insert_with(|| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `get_or_insert` instead
|
|
|
|
|
LL - let _ = deep.0.get_or_insert_with(|| 2);
|
|
LL + let _ = deep.0.get_or_insert(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:145:13
|
|
|
|
|
LL | let _ = deep.0.ok_or_else(|| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `ok_or` instead
|
|
|
|
|
LL - let _ = deep.0.ok_or_else(|| 2);
|
|
LL + let _ = deep.0.ok_or(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:177:28
|
|
|
|
|
LL | let _: Option<usize> = None.or_else(|| Some(3));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _: Option<usize> = None.or_else(|| Some(3));
|
|
LL + let _: Option<usize> = None.or(Some(3));
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:179:13
|
|
|
|
|
LL | let _ = deep.0.or_else(|| Some(3));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _ = deep.0.or_else(|| Some(3));
|
|
LL + let _ = deep.0.or(Some(3));
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Option::None`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:181:13
|
|
|
|
|
LL | let _ = opt.or_else(|| Some(3));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _ = opt.or_else(|| Some(3));
|
|
LL + let _ = opt.or(Some(3));
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:188:13
|
|
|
|
|
LL | let _ = res2.unwrap_or_else(|_| 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = res2.unwrap_or_else(|_| 2);
|
|
LL + let _ = res2.unwrap_or(2);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:190:13
|
|
|
|
|
LL | let _ = res2.unwrap_or_else(|_| astronomers_pi);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = res2.unwrap_or_else(|_| astronomers_pi);
|
|
LL + let _ = res2.unwrap_or(astronomers_pi);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:192:13
|
|
|
|
|
LL | let _ = res2.unwrap_or_else(|_| ext_str.some_field);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `unwrap_or` instead
|
|
|
|
|
LL - let _ = res2.unwrap_or_else(|_| ext_str.some_field);
|
|
LL + let _ = res2.unwrap_or(ext_str.some_field);
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:215:35
|
|
|
|
|
LL | let _: Result<usize, usize> = res.and_then(|_| Err(2));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `and` instead
|
|
|
|
|
LL - let _: Result<usize, usize> = res.and_then(|_| Err(2));
|
|
LL + let _: Result<usize, usize> = res.and(Err(2));
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:217:35
|
|
|
|
|
LL | let _: Result<usize, usize> = res.and_then(|_| Err(astronomers_pi));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `and` instead
|
|
|
|
|
LL - let _: Result<usize, usize> = res.and_then(|_| Err(astronomers_pi));
|
|
LL + let _: Result<usize, usize> = res.and(Err(astronomers_pi));
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:219:35
|
|
|
|
|
LL | let _: Result<usize, usize> = res.and_then(|_| Err(ext_str.some_field));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `and` instead
|
|
|
|
|
LL - let _: Result<usize, usize> = res.and_then(|_| Err(ext_str.some_field));
|
|
LL + let _: Result<usize, usize> = res.and(Err(ext_str.some_field));
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:222:35
|
|
|
|
|
LL | let _: Result<usize, usize> = res.or_else(|_| Ok(2));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _: Result<usize, usize> = res.or_else(|_| Ok(2));
|
|
LL + let _: Result<usize, usize> = res.or(Ok(2));
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:224:35
|
|
|
|
|
LL | let _: Result<usize, usize> = res.or_else(|_| Ok(astronomers_pi));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _: Result<usize, usize> = res.or_else(|_| Ok(astronomers_pi));
|
|
LL + let _: Result<usize, usize> = res.or(Ok(astronomers_pi));
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:226:35
|
|
|
|
|
LL | let _: Result<usize, usize> = res.or_else(|_| Ok(ext_str.some_field));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - let _: Result<usize, usize> = res.or_else(|_| Ok(ext_str.some_field));
|
|
LL + let _: Result<usize, usize> = res.or(Ok(ext_str.some_field));
|
|
|
|
|
|
|
error: unnecessary closure used to substitute value for `Result::Err`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:228:35
|
|
|
|
|
LL | let _: Result<usize, usize> = res.
|
|
| ___________________________________^
|
|
... |
|
|
LL | | or_else(|_| Ok(ext_str.some_field));
|
|
| |_______________________________________^
|
|
|
|
|
help: use `or` instead
|
|
|
|
|
LL - or_else(|_| Ok(ext_str.some_field));
|
|
LL + or(Ok(ext_str.some_field));
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:259:14
|
|
|
|
|
LL | let _x = false.then(|| i32::MAX + 1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| i32::MAX + 1);
|
|
LL + let _x = false.then_some(i32::MAX + 1);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:261:14
|
|
|
|
|
LL | let _x = false.then(|| i32::MAX * 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| i32::MAX * 2);
|
|
LL + let _x = false.then_some(i32::MAX * 2);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:263:14
|
|
|
|
|
LL | let _x = false.then(|| i32::MAX - 1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| i32::MAX - 1);
|
|
LL + let _x = false.then_some(i32::MAX - 1);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:265:14
|
|
|
|
|
LL | let _x = false.then(|| i32::MIN - 1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| i32::MIN - 1);
|
|
LL + let _x = false.then_some(i32::MIN - 1);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:267:14
|
|
|
|
|
LL | let _x = false.then(|| (1 + 2 * 3 - 2 / 3 + 9) << 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| (1 + 2 * 3 - 2 / 3 + 9) << 2);
|
|
LL + let _x = false.then_some((1 + 2 * 3 - 2 / 3 + 9) << 2);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:269:14
|
|
|
|
|
LL | let _x = false.then(|| 255u8 << 7);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| 255u8 << 7);
|
|
LL + let _x = false.then_some(255u8 << 7);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:271:14
|
|
|
|
|
LL | let _x = false.then(|| 255u8 << 8);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| 255u8 << 8);
|
|
LL + let _x = false.then_some(255u8 << 8);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:273:14
|
|
|
|
|
LL | let _x = false.then(|| 255u8 >> 8);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| 255u8 >> 8);
|
|
LL + let _x = false.then_some(255u8 >> 8);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:276:14
|
|
|
|
|
LL | let _x = false.then(|| i32::MAX + -1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| i32::MAX + -1);
|
|
LL + let _x = false.then_some(i32::MAX + -1);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:278:14
|
|
|
|
|
LL | let _x = false.then(|| -i32::MAX);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| -i32::MAX);
|
|
LL + let _x = false.then_some(-i32::MAX);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:280:14
|
|
|
|
|
LL | let _x = false.then(|| -i32::MIN);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| -i32::MIN);
|
|
LL + let _x = false.then_some(-i32::MIN);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:283:14
|
|
|
|
|
LL | let _x = false.then(|| 255 >> -7);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| 255 >> -7);
|
|
LL + let _x = false.then_some(255 >> -7);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:285:14
|
|
|
|
|
LL | let _x = false.then(|| 255 << -1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| 255 << -1);
|
|
LL + let _x = false.then_some(255 << -1);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:287:14
|
|
|
|
|
LL | let _x = false.then(|| 1 / 0);
|
|
| ^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| 1 / 0);
|
|
LL + let _x = false.then_some(1 / 0);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:289:14
|
|
|
|
|
LL | let _x = false.then(|| x << -1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| x << -1);
|
|
LL + let _x = false.then_some(x << -1);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:291:14
|
|
|
|
|
LL | let _x = false.then(|| x << 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| x << 2);
|
|
LL + let _x = false.then_some(x << 2);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:301:14
|
|
|
|
|
LL | let _x = false.then(|| x / 0);
|
|
| ^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| x / 0);
|
|
LL + let _x = false.then_some(x / 0);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:303:14
|
|
|
|
|
LL | let _x = false.then(|| x % 0);
|
|
| ^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| x % 0);
|
|
LL + let _x = false.then_some(x % 0);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:306:14
|
|
|
|
|
LL | let _x = false.then(|| 1 / -1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| 1 / -1);
|
|
LL + let _x = false.then_some(1 / -1);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:308:14
|
|
|
|
|
LL | let _x = false.then(|| i32::MIN / -1);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| i32::MIN / -1);
|
|
LL + let _x = false.then_some(i32::MIN / -1);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:311:14
|
|
|
|
|
LL | let _x = false.then(|| i32::MIN / 0);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| i32::MIN / 0);
|
|
LL + let _x = false.then_some(i32::MIN / 0);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:313:14
|
|
|
|
|
LL | let _x = false.then(|| 4 / 2);
|
|
| ^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| 4 / 2);
|
|
LL + let _x = false.then_some(4 / 2);
|
|
|
|
|
|
|
error: unnecessary closure used with `bool::then`
|
|
--> tests/ui/unnecessary_lazy_eval.rs:321:14
|
|
|
|
|
LL | let _x = false.then(|| f1 + f2);
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
help: use `then_some` instead
|
|
|
|
|
LL - let _x = false.then(|| f1 + f2);
|
|
LL + let _x = false.then_some(f1 + f2);
|
|
|
|
|
|
|
error: aborting due to 63 previous errors
|
|
|