ecstatic-morse
b3433c7cc9
Rollup merge of #76783 - lzutao:rd_impl_kind, r=GuillaumeGomez
...
Only get ImplKind::Impl once
With this, the code panics in one place instead of two.
2020-09-21 20:40:51 -07:00
Lzu Tao
2818032a2d
Calculate more correct capacity in merge_attrs
...
Co-authored-by: jyn514 <joshua@yottadb.com >
2020-09-18 01:55:40 +00:00
Lzu Tao
eede953c28
Only get ImplKind::Impl once
2020-09-16 09:08:41 +00:00
Lzu Tao
c743fc4342
Ignore rustc_private items from std docs
...
Apply suggestions from code review
Co-authored-by: Joshua Nelson <joshua@yottadb.com >
2020-09-13 05:30:49 +00:00
Joshua Nelson
868927fefb
rustdoc: Fix intra-doc links for cross-crate re-exports of traits
...
#58972 ignored extern_traits because before #65983 was fixed, they
would always fail to resolve, giving spurious warnings.
This undoes that change, so extern traits are now seen by the
`collect_intra_doc_links` pass. There are also some minor changes in
librustdoc/fold.rs to avoid borrowing the extern_traits RefCell more
than once at a time.
2020-08-29 17:21:26 -04:00
Ujjwal Sharma
a888b02884
rust_ast::ast => rustc_ast
2020-08-17 20:32:32 +00:00
Bastian Kauschke
cd53760cc7
merge as_local_hir_id with local_def_id_to_hir_id
2020-08-13 16:55:16 +02:00
Mark Rousskov
e24a0172b0
Only skip impls of foreign unstable traits
...
Previously unstable impls were skipped, which meant that any impl with an
unstable method would get skipped.
2020-07-19 16:39:20 -04:00
Manish Goregaokar
fc098170ce
Rollup merge of #74370 - Manishearth:re-spotlight, r=GuillaumeGomez
...
Reintroduce spotlight / "important traits" feature
(Reopened version of https://github.com/rust-lang/rust/pull/74111 because Github is broken, see discussion there)
Fixes https://github.com/rust-lang/rust/issues/73785
This PR reintroduces the "spotlight" ("important traits") feature.
A couple changes have been made:
As there were concerns about its visibility, it has been moved to be next to the return type, as opposed to being on the side.
It also no longer produces a modal, it shows the traits on hover, and it can be clicked on to pin the hover bubble.
It also works fine on mobile:
2020-07-16 11:18:55 -07:00
Manish Goregaokar
98450757e5
Revert "Remove "important traits" feature"
...
This reverts commit 1244ced958
2020-07-16 09:58:17 -07:00
Alex Crichton
fde8d11ca1
Don't pollute docs/suggestions with libstd deps
...
Currently dependency crates of the standard library can sometimes leak
into error messages such as when traits to import are suggested.
Additionally they can leak into documentation such as in the list of
"all traits implemented by `u32`". The dependencies of the standard
library, however, are intended to be private.
The dependencies of the standard library can't actually be stabl-y
imported nor is the documentation that relevant since you can't import
them on stable either. This commit updates both the compiler and rustdoc
to ignore unstable traits in these two scenarios.
Specifically the suggestion for traits to import ignore unstable traits,
and similarly the list of traits implemented by a type excludes unstable
traits.
This commit is extracted from #73441 where the addition of some new
dependencies to the standard library was showed to leak into various
error messages and documentation. The intention here is to go ahead and
land these changes ahead of that since it will likely take some time to
land.
2020-06-26 09:23:00 -07:00
Eric Huss
75983e137e
Support configurable deny-warnings for all in-tree crates.
2020-06-25 21:17:21 -07:00
marmeladema
4b7e44f893
rustdoc: remove calls to local_def_id_from_node_id
2020-05-30 12:30:58 +01:00
Camille GILLOT
d4e143ed2f
Remove ast::{Ident, Name} reexports.
2020-05-08 13:13:15 +02:00
Eduard-Mihai Burtescu
95b3c427d4
Remove Option from the return type of def_kind.
2020-04-24 13:44:07 -05:00
marmeladema
fe7531579d
Address comments from review
2020-04-23 23:14:07 +01:00
marmeladema
bfce24aa67
Modify as_local_hir_id to return a bare HirId
2020-04-23 23:14:07 +01:00
marmeladema
6148db719f
Modify as_local_hir_id to accept a LocalDefId instead of a DefId
2020-04-23 23:14:07 +01:00
Matthias Krüger
3837df2992
don't clone types that are copy (clippy::clone_on_copy)
2020-04-16 00:17:38 +02:00
marmeladema
555e024abc
librustc_middle: return LocalDefId instead of DefId in local_def_id_from_node_id
2020-04-10 12:13:54 +01:00
Mazdak Farrokhzad
0cb9e36090
rustc -> rustc_middle part 2
2020-03-30 07:16:56 +02:00
Mazdak Farrokhzad
f1701ddef1
rustc: remove rustc_hir_pretty dependency.
2020-03-24 08:44:55 +01:00
Yuki Okushi
8e17c8366c
Rollup merge of #69802 - matthiaskrgr:cl1ppy, r=Dylan-DPC
...
fix more clippy findings
* reduce references on match patterns (clippy::match_ref_pats)
* Use writeln!(fmt, "word") instead of write!(fmt, "word\n") (clippy::write_with_newline)
* libtest: remove redundant argument to writeln!() (clippy::writeln_empty_string)
* remove unneeded mutable references (cippy::unnecessary_mut_passed)
* libtest: declare variables as floats instead of casting them (clippy::unnecessary_cast)
* rustdoc: remove redundant static lifetimes (clippy::redundant_static_lifetimes)
* call .as_deref() instead of .as_ref().map(Deref::deref) (clippy::option_as_ref_deref)
* iterate over a maps values directly. (clippy::for_kv_map)
* rustdoc: simplify boolean condition (clippy::nonminimal_bool)
* Use ?-operator in more places (clippy::question_mark, had some false negatives fixed recently)
* rustdoc: Use .any(p) instead of find(p).is_some(). (clippy::search_is_some)
* rustdoc: don't call into_iter() on iterator. (clippy::identity_conversion)
2020-03-14 04:03:24 +09:00
Matthias Krüger
3244c84363
rustdoc: remove unused import
2020-03-11 14:24:07 +01:00
Mazdak Farrokhzad
61150353bf
Rollup merge of #69514 - GuillaumeGomez:remove-spotlight, r=kinnison
...
Remove spotlight
I had a few comments saying that this feature was at best misunderstood or not even used so I decided to organize a poll about on [twitter](https://twitter.com/imperioworld_/status/1232769353503956994 ). After 87 votes, the result is very clear: it's not useful. Considering the amount of code we have just to run it, I think it's definitely worth it to remove it.
r? @kinnison
cc @ollie27
2020-03-10 06:47:47 +01:00
Matthias Krüger
45108b195f
rustdoc: simplify boolean condition (clippy::nonminimal_bool)
2020-03-07 21:46:47 +01:00
Matthias Krüger
7aad89a900
Use ?-operator in more places (clippy::question_mark, had some false negatives fixed recently)
2020-03-07 21:46:47 +01:00
Vadim Petrochenkov
e08c279eac
Rename syntax to rustc_ast in source code
2020-02-29 21:59:09 +03:00
Guillaume Gomez
1244ced958
Remove "important traits" feature
2020-02-27 14:51:22 +01:00
Dylan MacKenzie
7f3ec5e50b
Make lookup of associated item by name O(log n)
2020-02-19 10:51:40 -08:00
Jonas Schievink
e0cb1ae24a
Make provided_trait_methods use impl Iterator
2020-02-08 14:37:40 +01:00
Jonas Schievink
66fd4e6ed8
Make associated_items query return a slice
2020-02-08 14:29:18 +01:00
Oliver Middleton
bbc2ae7590
rustdoc: Fix re-exporting primitive types
...
* Generate links to the primitive type docs for re-exports.
* Don't ICE on cross crate primitive type re-exports.
* Make primitive type re-exports show up cross crate.
2020-01-26 21:32:43 +00:00
Tyler Mandry
fca3264406
Rollup merge of #68204 - ecstatic-morse:item-kind-impl, r=oli-obk
...
Use named fields for `{ast,hir}::ItemKind::Impl`
Currently, the widely used `ItemKind::Impl` variant is a tuple with seven fields. I want to add an eighth in #68140 , which means I have to update most matches on this variant anyways. Giving a name to each field improves readability and makes future changes of this nature much simpler.
This change will cause several tools to break. I will fix them once this is merged.
2020-01-17 17:28:14 -08:00
Dylan MacKenzie
4743995ed3
Use named fields for hir::ItemKind::Impl
2020-01-17 16:14:29 -08:00
Guillaume Gomez
81a5b94ac6
formatting
2020-01-15 13:43:09 +01:00
Guillaume Gomez
12f029b7ee
Fix deref impl on type alias
2020-01-15 13:43:09 +01:00
Camille GILLOT
c1c09bee29
Move is_min_const_fn query to librustc_mir.
...
The only two uses of the associated methods are in librustc_mir and
librustdoc. Please tell me if there is a better choice.
2020-01-08 10:37:37 +01:00
Mazdak Farrokhzad
ebfd8673a7
Remove rustc_hir reexports in rustc::hir.
2020-01-05 12:49:22 +01:00
Mazdak Farrokhzad
7901c7f707
canonicalize FxHash{Map,Set} imports
2020-01-04 18:57:22 +01:00
Mazdak Farrokhzad
4ff12ce4c1
Normalize syntax::symbol imports.
2020-01-02 13:57:04 +01:00
Vadim Petrochenkov
70f1d57048
Rename syntax_pos to rustc_span in source code
2020-01-01 09:15:18 +03:00
Camille GILLOT
e2c9dd7a10
Retire HirVec.
2019-12-30 11:29:30 +01:00
Ohad Ravid
811bdeee00
Show value for consts in the documentation
2019-12-24 10:10:36 +01:00
Mark Rousskov
a06baa56b9
Format the world
2019-12-22 17:42:47 -05:00
Guillaume Gomez
0d7a49d356
Implement PrintWithSpace trait on hir::Mutability
2019-12-22 13:31:47 +01:00
Guillaume Gomez
5a0d747eef
Remove clean::Mutability enum
2019-12-21 21:19:03 +01:00
Vadim Petrochenkov
537895535d
syntax: Use ast::MacArgs for macro definitions
2019-12-02 21:56:34 +03:00
Vadim Petrochenkov
753ce4518e
rustc_metadata: Merge cstore.rs into creader.rs
2019-11-28 20:59:56 +03:00
Mazdak Farrokhzad
fb12c70852
rustc, rustc_passes: don't depend on syntax_expand.
...
This is done by moving some data definitions to syntax::expand.
2019-10-27 17:05:57 +01:00
