rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
1,105 Commits 1 Branch 0 Tags
d20eea4d47593b37f6355d6fb364aa9826770fd8
Commit Graph

383 Commits

Author SHA1 Message Date
Patryk Wychowaniec
d20eea4d47 fix: Add #[avr_skip] for bit shifts 
This commit follows the same logic as:

- https://github.com/rust-lang/compiler-builtins/pull/462
- https://github.com/rust-lang/compiler-builtins/pull/466

I've tested the changes by preparing a simple program:

```rust
fn calc() -> ... {
    let x = hint::black_box(4u...); // 4u8, 4u16, 4u32, 4u64, 4u128 + signed
    let y = hint::black_box(1u32);

    // x >> y
    // x << y
}

fn main() -> ! {
    let dp = arduino_hal::Peripherals::take().unwrap();
    let pins = arduino_hal::pins!(dp);
    let mut serial = arduino_hal::default_serial!(dp, pins, 57600);

    for b in calc().to_le_bytes() {
        _ = ufmt::uwrite!(&mut serial, "{} ", b);
    }

    _ = ufmt::uwriteln!(&mut serial, "");

    loop {
        //
    }
}
```

... switching types & operators in `calc()`, and observing the results;
what I ended up with was:

```
 u32 << u32 - ok
 u64 << u32 - ok
u128 << u32 - error (undefined reference to `__ashlti3')
 i32 >> u32 - ok
 i64 >> u32 - ok
i128 >> u32 - error (undefined reference to `__ashrti3')
 u32 >> u32 - ok
 u64 >> u32 - ok
u128 >> u32 - error (undefined reference to `__lshrti3')

(where "ok" = compiles and returns correct results)
```

As with multiplication and division, so do in here 128-bit operations
not work, because avr-gcc's standard library doesn't provide them (at
the same time, requiring that specific calling convention, making it
pretty difficult for compiler-builtins to jump in).

I think 128-bit operations non-working on an 8-bit controller is an
acceptable trade-off - 😇 - and so the entire fix in here is
just about skipping those functions.
 2022-12-25 11:46:30 +01:00
Martin Kröning
620f50589e Expose minimal floating point symbols for x86_64-unknown-none 2022-12-07 16:08:01 +01:00
Jérome Eertmans
80828bfb0b fix(docs): typo in docstrings 
Hello, I think you misspelled `width` to `with`.
 2022-11-28 10:53:42 +01:00
Jules Bertholet
af5664be84 Update libm, add rint and rintf 2022-11-08 21:04:02 -05:00
Felix S. Klock II
2faf57c08d might as well add the link to the LLVM assembly code as well. 2022-10-25 12:32:41 -04:00
Felix S. Klock II
8266a1343b Document origins of the multiplication method being used here. 2022-10-25 11:25:14 -04:00
Ralf Jung
6267545315 invoke the unreachable intrinsic, not the stable wrapper 2022-10-10 19:34:48 +02:00
Amanieu d'Antras
2e0590c997 Fix clippy lints 2022-10-10 17:40:16 +01:00
Lokathor
f6cd5cf806 Update macros.rs 2022-09-27 13:22:45 -06:00
D1plo1d
1d5b952100 math: Enabled floating point intrinsics for RISCV32 microcontrollers 2022-09-17 11:47:21 -04:00
David Hoppenbrouwers
a695cf95cf Remove c32() from x86_64 memcmp 
Fixes https://github.com/rust-lang/compiler-builtins/issues/487
 2022-08-10 11:29:38 +02:00
Nicholas Bishop
abb6893a85 Enable unadjusted_on_win64 for UEFI in some cases 
The conversion functions from i128/u128 to f32/f64 have the
`unadjusted_on_win64` attribute, but it is disabled starting with
LLVM14. This seems to be the correct thing to do for Win64, but for some
reason x86_64-unknown-uefi is different, despite generally using the
same ABI as Win64.
 2022-08-03 19:16:03 -04:00
Amanieu d'Antras
b71753da80 Merge pull request #484 from Alexhuszagh/armv5te 2022-07-30 02:42:08 +02:00
Amanieu d'Antras
a81a868a59 Merge pull request #482 from ankane/gamma 2022-07-30 02:41:21 +02:00
Alex Huszagh
599dcc2c46 Add compiler-rt fallbacks for sync builtins on armv5te-musl. 2022-07-29 16:58:05 -05:00
Andrew Kane
89df6f6bc0 Added tgamma and tgammaf 2022-07-28 16:21:37 -07:00
David Hoppenbrouwers
66f22e0931 Remove branches around rep movsb/stosb 
While it is measurably faster for older CPUs, removing them keeps the code
smaller and is likely more beneficial for newer CPUs.
 2022-07-28 18:45:28 +02:00
David Hoppenbrouwers
04c223f0df Skip rep movsb in copy_backward if possible 
There is currently no measureable performance difference in benchmarks
but it likely will make a difference in real workloads.
 2022-07-28 18:32:57 +02:00
David Hoppenbrouwers
30e0c1f4c2 Use att_syntax for now 2022-07-28 18:32:56 +02:00
David Hoppenbrouwers
897a133869 Remove rep_param_rev 2022-07-28 18:32:56 +02:00
David Hoppenbrouwers
45e2996c96 Fix suboptimal codegen in memset 2022-07-28 18:32:56 +02:00
David Hoppenbrouwers
a977b01090 Align destination in mem* instructions. 
While misaligned reads are generally fast, misaligned writes aren't and
can have severe penalties.
 2022-07-28 18:32:51 +02:00
Amanieu d'Antras
0cc9a7e4a6 Merge pull request #478 from Lokathor/weak-linkage-for-division 2022-07-28 18:14:59 +02:00
Nicholas Bishop
586e2b38ef Enable win64_128bit_abi_hack for x86_64-unknown-uefi 
The `x86_64-unknown-uefi` target is Windows-like [1], and requires the
same altered ABI for some 128-bit integer intrinsics.

See also https://github.com/rust-lang/rust/issues/86494.

[1]: https://github.com/rust-lang/rust/blob/master/compiler/rustc_target/src/spec/x86_64_unknown_uefi.rs
 2022-07-28 11:55:59 -04:00
Lokathor
8568a33255 restrict linkage to platforms using ELF binaries 
on windows and apple (which don't use ELF) we can't apply weak linkage
 2022-07-28 09:42:18 -06:00
Lokathor
1070134a56 Merge pull request #1 from rust-lang/master 
updates from main
 2022-07-28 09:36:02 -06:00
Ayush Singh
f2ac36348c Use all of src/math for UEFI 
This is needed for libtest
 2022-07-28 20:51:44 +05:30
Lokathor
011f92c877 add weak linkage to the ARM AEABI division functions 2022-07-22 17:14:18 -06:00
Amanieu d'Antras
d14c5a43b7 Merge pull request #471 from Demindiro/x86_64-fix-recursive-memcmp 2022-06-12 02:19:30 +02:00
David Hoppenbrouwers
08f4f4007d Fix infinite recursion in x86_64 memcmp if SSE2 is not present 
Fixes #470
 2022-06-11 09:20:01 +02:00
Sean Cross
7cdad114a5 math: compile math functions for Xous 
This adds support for Xous, enabling users to call math functions on
primitives such as `cos()`.

Signed-off-by: Sean Cross <sean@xobs.io>
 2022-06-09 09:12:44 +08:00
David Hoppenbrouwers
cb63d7d500 Use unchecked_div/rem 2022-05-31 08:20:30 +02:00
David Hoppenbrouwers
b94e93ead8 Slightly optimize main (32b) memcmp loop 
It only seems to save a single instruction at first sight yet the
effects are significant.
 2022-05-28 22:46:16 +02:00
David Hoppenbrouwers
95d2cd5502 Fix rustfmt sillyness 2022-05-28 08:16:46 +02:00
David Hoppenbrouwers
217748f91b Fix panic not being optimized out. 
I don't know why it isn't being optimized out though, which worries
me.
 2022-05-28 01:24:17 +02:00
David Hoppenbrouwers
2071d05a19 Always inline compare_bytes::cmp 2022-05-28 00:50:05 +02:00
David Hoppenbrouwers
e7a8932e3b Fix CI, better memcmp tests 2022-05-28 00:10:55 +02:00
David Hoppenbrouwers
4dbd8387f9 Implement faster memcmp for x86_64 
x86_64 can load unaligned words in a single cache line as fast as
aligned words. Even when crossing cache or page boundaries it is just as
fast to do an unaligned word read instead of multiple byte reads.

Also add a couple more tests & benchmarks.
 2022-05-27 21:58:39 +02:00
Amanieu d'Antras
18623bffad Merge pull request #464 from m-ou-se/floatconv2 2022-05-26 20:53:14 +02:00
Mara Bos
ca517a25e7 Explicitly use parentheses for associativity of shift operators. 2022-05-26 17:21:21 +02:00
Patryk Wychowaniec
ac47841ce2 Add avr_skip for __udivti3 & __umodti3 2022-05-24 19:49:08 +02:00
Amanieu d'Antras
092bbb67d4 Merge pull request #465 from thomcc/cast-before-transmute 2022-05-24 19:24:15 +02:00
Amanieu d'Antras
f1fe94e882 Merge pull request #462 from Patryk27/avr 2022-05-24 16:41:59 +02:00
Thom Chiovoloni
dcdd9bbc56 Avoid int to ptr transmute by casting first 2022-05-23 23:34:10 -07:00
Mara Bos
425c78ee7a Faster int<->float conversions. 2022-05-20 16:25:18 +02:00
Mara Bos
7ed26a7e7a De-duplicate 128 bit float conv intrinsics using cfg_attr. 2022-05-20 15:04:36 +02:00
Mara Bos
2063e07b35 Support cfg_attr attributes in intrinsics!() macro. 2022-05-20 15:01:50 +02:00
Patryk Wychowaniec
a695a800d5 Fix division on AVRs 
For division and modulo, AVR uses a custom calling convention that does
not match compiler_builtins' expectations, leading to non-working code¹.

Ideally we'd just use hand-written naked functions (as, afair, ARM
does), but that's a lot of code to port², so hopefully we'll be able to
do it gradually later.

For the time being, I'd suggest not compiling problematic functions for
AVR target - this causes avr-gcc (which is a mandatory part of Rust+AVR
toolchain anyway) to link hand-written assembly from libgcc, which is
confirmed to work.

I've tested the code locally on simavr and the patch seems to be working
correctly :-)

¹ https://github.com/rust-lang/rust/issues/82242,
  https://github.com/rust-lang/rust/issues/83281
² 31048012db/libgcc/config/avr/lib1funcs.S

Closes https://github.com/rust-lang/rust/issues/82242
Closes https://github.com/rust-lang/rust/issues/83281
 2022-05-17 23:21:45 +02:00
Johannes Stoelp
65ec71d386 rv32 rv64: adapt conditional compilation 
Adapt conditional compilation as:
rv32i : riscv:__mulsi3, riscv:__muldi3
rv32im: riscv:__mulsi3, int/mul:__muldi3
rv64i : riscv:__mulsi3, riscv:__muldi3
rv64im: riscv:__mulsi3, int/mul:__muldi3
 2022-05-12 00:34:49 +02:00
Johannes Stoelp
10971912e8 rv64 implement muldi3 intrinsic 
Implement the __muldi3 intrinsic to prevent infinite recursion during
multiplication on rv64 without the 'm' extension.
 2022-05-02 23:00:12 +02:00