IceSentry
cba694c602
better &mut and & matching
2020-04-08 19:26:47 -04:00
IceSentry
de6db06322
ignore &mut and & when checking params
2020-04-08 19:07:21 -04:00
IceSentry
a2dc18f71a
remove TODO
2020-04-08 18:11:24 -04:00
IceSentry
2a582b78a5
Add more heuristics for hiding obvious param hints
...
This will now hide "value", "pat", "rhs" and "other"
These words were selected from the std because they are used in common functions with only a single param and are obvious by their use.
I think it would be good to also hide "bytes" if the type is `[u8; n]` but I'm not sure how to get the param type signature
It will also hide the hint if the passed param starts or end with the param_name
2020-04-08 17:48:16 -04:00
Josh Mcguigan
36c110ee09
match checking add additional test for match checking tuple with missing pattern
2020-04-08 10:47:05 -07:00
Josh Mcguigan
941615748d
fix panic in match checking when tuple enum missing pattern
2020-04-08 10:47:05 -07:00
Benjamin Coenen
8f1dba6f9a
feat: add attributes support on struct fields and method #3870
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com >
2020-04-08 18:12:15 +02:00
Luca Barbieri
68196ccc10
Add AstElement trait, generate tokens, support tokens in enums
...
- Adds a new AstElement trait that is implemented by all generated
node, token and enum structs
- Overhauls the code generators to code-generate all tokens, and
also enhances enums to support including tokens, node, and nested
enums
2020-04-08 17:15:12 +02:00
Luca Barbieri
35a69d09ee
Fix warnings emitted when compiling as part of rustc
2020-04-08 14:49:19 +02:00
bors[bot]
8ea7c9cb62
Merge #3826
...
3826: Flatten nested highlight ranges during DFS traversal r=matklad a=ltentrup
Implements the flattening of nested highlights from #3447 .
There is a caveat: I needed to add `Clone` to `HighlightedRange` to split highlight ranges ~and the nesting does not appear in the syntax highlighting test (it does appear in the accidental-quadratic test but there it is not checked against a ground-truth)~.
I have added a test case for the example mentioned in #3447 .
Co-authored-by: Leander Tentrup <leander.tentrup@gmail.com >
2020-04-08 12:00:08 +00:00
bors[bot]
9aa3bca536
Merge #3892
...
3892: Add L_DOLLAR for TYPE_RECOVERY_SET r=matklad a=edwin0cheng
This PR is a hot fix for issue #3861 that just prevent it make the parser being stuck.
The actual problem described in https://github.com/rust-analyzer/rust-analyzer/pull/3873#issuecomment-610208693 is a very deep rabbit hole I don't want to dig right now :(
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com >
2020-04-08 10:51:46 +00:00
Edwin Cheng
53d05448c1
Add L_DOLLAR for TYPE_RECOVERY_SET
2020-04-08 18:34:20 +08:00
Aleksey Kladov
9e3c843847
fmt
2020-04-08 12:19:41 +02:00
Aleksey Kladov
4c29214bba
Move computation of missing fields into hir
2020-04-07 18:34:17 +02:00
Aleksey Kladov
7819d99d6b
Add functional update test
2020-04-07 18:25:47 +02:00
Aleksey Kladov
d8f6013404
Fix names of test modules
2020-04-07 18:23:18 +02:00
Benjamin Coenen
18a5e16483
Merge branch 'master' of github.com:rust-analyzer/rust-analyzer
2020-04-07 17:59:09 +02:00
Benjamin Coenen
ab864ed259
feat: add attributes support on struct fields #3870
...
Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com >
2020-04-07 17:58:05 +02:00
bors[bot]
33c364b545
Merge #3878
...
3878: A more precise panic macro r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com >
2020-04-07 14:41:07 +00:00
Aleksey Kladov
3bde2b7423
A more precise panic macro
2020-04-07 16:40:39 +02:00
Aleksey Kladov
5540193fc8
Don't insert !() if there's already some
2020-04-07 16:37:33 +02:00
Aleksey Kladov
73ccf7f495
Reorder imports
2020-04-07 15:07:18 +02:00
Josh Mcguigan
9fc1f51b7a
add fixme to use type checker rather than manually comparing types
2020-04-07 05:17:59 -07:00
Josh Mcguigan
a208de15b7
PR feedback implementation
2020-04-07 05:12:08 -07:00
Josh Mcguigan
da6752d5f9
missing match arms diagnostic change source to match expression
2020-04-07 05:12:08 -07:00
Josh Mcguigan
5fe608fb31
handle match auto-deref
2020-04-07 05:12:08 -07:00
Josh Mcguigan
5b4316377b
improving documentation
2020-04-07 05:12:08 -07:00
Josh Mcguigan
43dfd89493
handle non matching enum pattern types
2020-04-07 05:12:08 -07:00
Josh Mcguigan
b87b7a088f
remove panics
2020-04-07 05:12:08 -07:00
Josh Mcguigan
8c378af721
missing match arms diagnostic
2020-04-07 05:12:08 -07:00
Aleksey Kladov
0215560434
Better naming for scope completion
2020-04-07 13:20:41 +02:00
Aleksey Kladov
a5ffe53c9d
Better naming for path completion
2020-04-07 13:19:57 +02:00
Aleksey Kladov
79b48a9e77
Merge pull request #3863 from Veetaha/feature/migrate-to-rast
...
Migrate tests .txt -> .rast
2020-04-07 13:10:43 +02:00
Aleksey Kladov
baf9fcc38e
Merge pull request #3866 from lnicola/fewer-braces
...
Fix unnecessary braces warnings
2020-04-07 09:22:33 +02:00
Josh Mcguigan
8f7fceeb9c
fix cargo check config with custom command
2020-04-06 21:41:31 -07:00
Leander Tentrup
bf96d46fee
Simplify HTML highlighter and add test case for highlight_injection logic
2020-04-06 23:00:09 +02:00
Florian Diebold
236ac630f6
Fix Chalk panic
...
Fixes #3865 . Basically I forgot to shift 'back' when we got `dyn Trait`s back
from Chalk, so after going through Chalk a few times, the panic happened.
2020-04-06 17:26:26 +02:00
Aleksey Kladov
109bb1a793
Merge pull request #3867 from matklad/deny-eprintln
...
Check for eprintlns on CI
2020-04-06 17:21:47 +02:00
Edwin Cheng
4f70162f54
Add bridge::TokenStream to crate scope
2020-04-06 23:07:48 +08:00
Edwin Cheng
b2844917ad
Add proc_macro mod (copy from lib_proc_macro)
2020-04-06 23:07:48 +08:00
Edwin Cheng
40616fdb49
Refactor deps
2020-04-06 23:07:48 +08:00
Aleksey Kladov
bf569f8b29
Check for eprintln on CI
2020-04-06 17:00:18 +02:00
Laurențiu Nicola
52fd2c8e48
Fix unnecessary braces warnings
2020-04-06 17:21:33 +03:00
Edwin Cheng
a569a19ef4
Use log info in trait_solve_query
2020-04-06 21:01:58 +08:00
veetaha
da091b1303
Migrate tests .txt -> .rast
...
The sytax tree output files now use .rast extension
(rust-analyzer syntax tree or rust abstract syntax tree
(whatever)).
This format has a editors/code/ra_syntax_tree.tmGrammar.json declaration
that supplies nice syntax highlighting for .rast files.
2020-04-06 14:04:26 +03:00
Aleksey Kladov
ec3fb1cdb4
Merge pull request #3853 from matklad/cf
...
Make control token modifier less ambiguous
2020-04-06 11:53:56 +02:00
bors[bot]
972816b6d4
Merge #3843
...
3843: Remove rustc_lexer dependency in favour of rustc-ap-rustc_lexer r=est31 a=est31
The latter is auto-published on a regular schedule (Right now weekly).
See also https://github.com/alexcrichton/rustc-auto-publish
Co-authored-by: est31 <MTest31@outlook.com >
2020-04-06 08:42:52 +00:00
bors[bot]
4f904b2970
Merge #3829
...
3829: Adds to SSR match for semantically equivalent call and method call r=matklad a=mikhail-m1
#3186
maybe I've missed some corner cases, but it works in general
Co-authored-by: Mikhail Modin <mikhailm1@gmail.com >
2020-04-06 08:15:48 +00:00
est31
2f6914824a
Remove rustc_lexer dependency in favour of rustc-ap-rustc_lexer
...
The latter is auto-published on a regular schedule (Right now weekly).
2020-04-06 10:08:51 +02:00
Aleksey Kladov
48bc0ca745
Make control token modifier less ambiguous
...
In textmate, keyword.control is used for all kinds of things; in fact,
the default scope mapping for keyword is keyword.control!
So let's add a less ambiguous controlFlow modifier
See Microsoft/vscode#94367
2020-04-06 09:57:50 +02:00