rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
214,676 Commits 1 Branch 0 Tags
8ecaad85f61375b18e1667b51a3ef350121d2ca0
Commit Graph

20720 Commits

Author SHA1 Message Date
Matthias Krüger
6e6ec81a91 Rollup merge of #105860 - Ezrashaw:add-long-errors-0460-0457, r=jruderman,GuillaumeGomez 
Add long error docs for `E0460` and `E0457`

Final docs for errors in #61137 that have UI tests, my next PRs will also add these tests.

r? ``@GuillaumeGomez``
 2022-12-19 20:54:57 +01:00
Andrew Pollack
8441ca5d81 Revert "Replace usage of ResumeTy in async lowering with Context" 2022-12-19 11:24:59 -08:00
bors
935dc07218 Auto merge of #103600 - compiler-errors:early-binder-nits, r=spastorino 
Address some `EarlyBinder` nits
 2022-12-19 19:21:35 +00:00
Michael Goulet
8c86773fd3 Make fast-path for implied wf lint better 2022-12-19 19:04:55 +00:00
Michael Goulet
c40ededa10 Downgrade IMPLIED_BOUNDS_ENTAILMENT to warn by default, add it to builtin lint list 2022-12-19 18:16:22 +00:00
Michael Goulet
96154d7fa7 Add IMPLIED_BOUNDS_ENTAILMENT lint 2022-12-19 18:16:22 +00:00
lcnr
a213bb36c9 implement the skeleton of the updated trait solver 2022-12-19 16:46:17 +00:00
Yiming Lei
bd12d151ee add function to tell if the current ambiguity error matches a previous one in ambiguity_errors 
if 2 errors of the kind and ident and span of the ident, b1, b2 and misc1 misc2 are the same
then these 2 ambiguity errors matched
prevent identical ambiguity error from pushing into vector of ambiguity_errors
this will fix #105177
 2022-12-19 08:38:05 -08:00
Rémy Rakic
8275d115fb Revert "Auto merge of #103880 - b-naber:field-ty-mir, r=lcnr" 
This reverts commit 03770f0e2b, reversing
changes made to 01ef4b21dc.
 2022-12-19 15:31:20 +00:00
Ezra Shaw
5ecac8ede6 more markdown list formatting 
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
 2022-12-19 22:50:31 +13:00
Dylan DPC
3350ae9cef Rollup merge of #105882 - compiler-errors:issue-105832, r=jackh726 
Don't ICE in closure arg borrow suggestion

Fixes #105832
 2022-12-19 14:41:36 +05:30
Dylan DPC
a9005b6cc0 Rollup merge of #105864 - matthiaskrgr:compl, r=Nilstrieb 
clippy::complexity fixes

filter_next
needless_question_mark
bind_instead_of_map
manual_find
derivable_impls
map_identity
redundant_slicing
skip_while_next
unnecessary_unwrap
needless_bool

r? `@compiler-errors`
 2022-12-19 14:41:35 +05:30
Dylan DPC
90035f130e Rollup merge of #105839 - LegionMammal978:mut-upvar-not-send, r=lcnr 
Suggest a `T: Send` bound for `&mut T` upvars in `Send` generators

Right now, we suggest a `T: Sync` bound for both `&T` and `&mut T` upvars. A user on URLO [found this confusing](https://users.rust-lang.org/t/error-complains-about-missing-sync-but-send-is-whats-missing/86021), so I wrote this quick fix to look at the mutability before making the suggestion.
 2022-12-19 14:41:35 +05:30
bors
a474ebbc4e Auto merge of #105883 - matthiaskrgr:rollup-v5n53t1, r=matthiaskrgr 
Rollup of 8 pull requests

Successful merges:

 - #105419 (Add tests for #41731)
 - #105447 (Add a test for #103095)
 - #105842 (print argument name in arg mismatch if possible)
 - #105863 (Update browser-ui-test version to reduce GUI tests flakyness)
 - #105867 (remove redundant fn params that were only "used" in recursion)
 - #105869 (don't clone Copy types)
 - #105873 (use &str / String literals instead of format!())
 - #105879 (Revert "Introduce lowering_arena to avoid creating AST nodes on the fly")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
 2022-12-19 01:13:58 +00:00
Matthias Krüger
1da4a49912 clippy::complexity fixes 
filter_next
needless_question_mark
bind_instead_of_map
manual_find
derivable_impls
map_identity
redundant_slicing
skip_while_next
unnecessary_unwrap
needless_bool
 2022-12-19 00:04:28 +01:00
Matthias Krüger
87a4694825 Rollup merge of #105879 - Nilstrieb:revert-hir-arena, r=oli-obk 
Revert "Introduce lowering_arena to avoid creating AST nodes on the fly"

This reverts commit d9a1faaa9c (#101499).

This was originally part of #101345 which has now been closed as a different approach is taken now.

r? `@oli-obk`

cc `@spastorino`
 2022-12-18 23:03:08 +01:00
Matthias Krüger
ebe3563764 Rollup merge of #105873 - matthiaskrgr:clippy_fmt, r=Nilstrieb 
use &str / String literals instead of format!()
 2022-12-18 23:03:07 +01:00
Matthias Krüger
221e71e7a1 Rollup merge of #105869 - matthiaskrgr:clone_on_copy, r=compiler-errors 
don't clone Copy types
 2022-12-18 23:03:07 +01:00
Matthias Krüger
e96166eb42 Rollup merge of #105867 - matthiaskrgr:rec_param, r=compiler-errors 
remove redundant fn params that were only "used" in recursion
 2022-12-18 23:03:06 +01:00
Matthias Krüger
f5656ad3c7 Rollup merge of #105842 - compiler-errors:arg-name-sugg, r=petrochenkov 
print argument name in arg mismatch if possible

A bit more contextual than just `/* value */`, at least when the argument is named something related to its context.

The UI test cases are... not super convincing, but also they're minimized tests.
 2022-12-18 23:03:05 +01:00
bors
2b094b1ede Auto merge of #105446 - erikdesjardins:vt-size, r=nikic 
Add 0..=isize::MAX range metadata to size loads from vtables

This is the (much belated) size counterpart to #91569.

Inspired by https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/Range.20metadata.20for.20.60size_of_val.60.20and.20other.20isize.3A.3AMAX.20limits. This could help optimize layout computations based on the size of a dyn trait. Though, admittedly, adding this to vtables wouldn't be as beneficial as adding it to slice len, which is used much more often.

Miri detects this UB already: b7cc99142a/compiler/rustc_const_eval/src/interpret/traits.rs (L119-L121)
(In fact Miri goes further, [assuming a 48-bit address space on 64-bit platforms](9db224fc90/compiler/rustc_abi/src/lib.rs (L312-L331)), but I don't think we can assume that in an optimization.)
 2022-12-18 22:01:39 +00:00
Michael Goulet
dd8897eb63 Don't ICE in closure arg borrow suggestion 2022-12-18 21:41:29 +00:00
Nilstrieb
8bfd6450c7 A few small cleanups for newtype_index 
Remove the `..` from the body, only a few invocations used it and it's
inconsistent with rust syntax.

Use `;` instead of `,` between consts. As the Rust syntax gods inteded.
 2022-12-18 21:47:28 +01:00
Nilstrieb
d679764fb6 Make #[debug_format] an attribute in newtype_index 
This removes the `custom` format functionality as its only user was
trivially migrated to using a normal format.

If a new use case for a custom formatting impl pops up, you can add it
back.
 2022-12-18 21:37:38 +01:00
Nilstrieb
91c3c2040c Make #[max] an attribute in newtype_index 2022-12-18 21:22:14 +01:00
Nilstrieb
93429948cf Make #[no_ord_impl] an attribute in newtype_index 2022-12-18 21:06:44 +01:00
Nilstrieb
88d5f7f4ce Make #[custom_encodable] an attribute for newtype_index 
Makes the syntax a little more rusty.
 2022-12-18 21:02:14 +01:00
Ezra Shaw
540c3f434f docs: add long-form error-code docs for E0457 2022-12-19 08:55:08 +13:00
Ezra Shaw
7e66d451ad docs: add long-form error-code docs for E0460 2022-12-19 08:55:08 +13:00
Nilstrieb
b4d739ef12 Use #[derive] instead of custom syntax in all newtype_index 2022-12-18 20:53:08 +01:00
Nilstrieb
d59a2ac2bc Revert "Introduce lowering_arena to avoid creating AST nodes on the fly" 
This reverts commit d9a1faaa9c.

This was originally part of a larger PR that has now been closed as a
different approach is taken now.
 2022-12-18 20:28:59 +01:00
Matthias Krüger
22379779b5 Rollup merge of #105875 - matthiaskrgr:needless_borrowed_reference, r=oli-obk 
don't destuct references just to reborrow
 2022-12-18 18:57:05 +01:00
Matthias Krüger
8892698903 Rollup merge of #105870 - matthiaskrgr:useless_conv, r=oli-obk 
avoid .into() conversion to identical types
 2022-12-18 18:57:05 +01:00
Matthias Krüger
08ecb91db5 Rollup merge of #105854 - matthiaskrgr:rmclone, r=compiler-errors 
remove redundant clone
 2022-12-18 18:57:03 +01:00
Matthias Krüger
f2f297a4f8 Rollup merge of #105420 - tmiasko:dest-prop-dead-code, r=JakobDegen 
Remove dead code after destination propagation

Fixes #105428.

cc `@JakobDegen`
 2022-12-18 18:57:03 +01:00
Matthias Krüger
a108d55ce6 don't restuct references just to reborrow 2022-12-18 17:04:32 +01:00
Matthias Krüger
0aa4cde747 avoid .into() conversion to identical types 2022-12-18 16:20:32 +01:00
Matthias Krüger
3af7df91fc use &str / String literals instead of format!() 2022-12-18 16:17:46 +01:00
Matthias Krüger
6e52a0f421 remove redundant fn params that were only "used" in recursion 2022-12-18 14:27:07 +01:00
Matthias Krüger
fec9e9ecf1 don't clone Copy types 2022-12-18 14:25:55 +01:00
bors
35a99eef32 Auto merge of #104417 - mejrs:mir_build, r=davidtwco 
Migrate rustc_mir_build diagnostics

Rebases https://github.com/rust-lang/rust/pull/100854

~~The remaining issue is how to better resolve 72bea68af4~~

~~The diagnostic macros seems to generate a broken diagnostic, and I couldn't figure out how to manually format the fluent message, so I hardcoded the format string for now. I'd like pointers to a better fix for this.~~

Also, I'm not 100% sure I didn't mess up a rebase somewhere 🙂

r? `@davidtwco`
 2022-12-18 08:53:49 +00:00
Michael Goulet
5cccb36cfb higher-ranked lifetime message 2022-12-18 03:04:26 +00:00
Matthias Krüger
1ade25491e remove redundant clone 2022-12-18 00:29:25 +01:00
Matthias Krüger
eaf2f26ecc Rollup merge of #105814 - JakobDegen:custom-mir-terms, r=oli-obk 
Support call and drop terminators in custom mir

The only caveat with this change is that cleanup blocks are not supported. I would like to add them, but it's not quite clear to me what the best way to do that is, so I'll have to think about it some more.

r? ``@oli-obk``
 2022-12-17 23:44:28 +01:00
Matthias Krüger
a8ad7f64a1 Rollup merge of #105792 - Ezrashaw:add-e0320-long-docs, r=GuillaumeGomez 
docs: add long error explanation for error E0320

Continuation of #105791

r? ``@GuillaumeGomez``
 2022-12-17 23:44:28 +01:00
Michael Goulet
c1181e1224 Ensure param-env is const before calling eval_to_valtree 2022-12-17 22:33:06 +00:00
Michael Goulet
7df33a093c Account for RPITITs in opt_suggest_box_span 2022-12-17 22:26:59 +00:00
Michael Goulet
f034cb431d print argument name in arg mismatch if possible 2022-12-17 20:59:25 +00:00
Matthew House
ee53452aec Suggest a T: Send bound for &mut T upvars in Send generators 2022-12-17 15:21:37 -05:00
Michael Goulet
4042f55079 Don't ICE in check_must_not_suspend_ty for mismatched tuple arity 2022-12-17 19:20:29 +00:00