Esteban Küber
b3fba5e18a
Remove unnecessary code and account for turbofish suggestion
...
Remove previously existing fallback that tried to give a good turbofish
suggestion, `need_type_info` is already good enough.
Special case `::<Vec<_>` suggestion for `Iterator::collect`.
2022-12-13 10:39:44 -08:00
Esteban Küber
9d5e7d3c04
Suggest collecting into Vec<_>
2022-12-13 10:39:44 -08:00
Esteban Küber
cf0b6b9337
Account for dereference expressions
2022-12-13 10:06:15 -08:00
Esteban Küber
b8bd1d0826
Fix span for &mut removal suggestion
2022-12-13 10:06:14 -08:00
Esteban Küber
dd72b1a0df
Suggest ref for some patterns as a fallback
2022-12-13 10:06:14 -08:00
Esteban Küber
4f7c257fd8
Do not suggest borrowing binding in pattern in let else
...
Fix #104838 .
2022-12-13 10:06:13 -08:00
Esteban Küber
e46416eed6
Change pattern borrowing suggestions to be verbose
...
Synthesize a more accurate span and use verbose suggestion output to
make the message clearer.
2022-12-13 10:06:13 -08:00
Michael Goulet
99417d54af
Address a few more nits
2022-12-13 17:56:04 +00:00
Michael Goulet
fbe66a6ef3
Address nits
...
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de >
2022-12-13 17:56:04 +00:00
Michael Goulet
7196973c3e
Remove chalk lowering for AliasTy
2022-12-13 17:48:55 +00:00
Michael Goulet
0f9e414092
nit: docs
2022-12-13 17:48:55 +00:00
Michael Goulet
4b19a2c119
Combine OfOpaque and OfProjection
2022-12-13 17:48:55 +00:00
Michael Goulet
96cb18e864
Combine identical alias arms
2022-12-13 17:48:55 +00:00
Michael Goulet
61adaf8187
Combine projection and opaque into alias
2022-12-13 17:48:55 +00:00
Michael Goulet
c13bd83528
squash OpaqueTy and ProjectionTy into AliasTy
2022-12-13 17:40:27 +00:00
Michael Goulet
5c6afb850c
ProjectionTy.item_def_id -> ProjectionTy.def_id
2022-12-13 17:34:44 +00:00
Michael Goulet
7f3af72606
Use ty::OpaqueTy everywhere
2022-12-13 17:29:26 +00:00
Michael Goulet
918ede6474
make Opaque have one field: OpaqueTy
2022-12-13 17:27:41 +00:00
Nilstrieb
8b2a7da3b0
Rename assert_uninit_valid intrinsic
...
It's not about "uninit" anymore but about "filling with 0x01 bytes" so
the name should at least try to reflect that.
2022-12-13 18:08:35 +01:00
Jacob Bramley
73d374f3e7
bug! if branch-protection makes it to non-AArch64 codegen.
2022-12-13 17:04:02 +00:00
akida31
757396f5fe
tidy: ignore filelength
2022-12-13 16:37:44 +01:00
akida31
f780faa8c4
reduce to single suggestion for all arguments
2022-12-13 16:30:04 +01:00
akida31
4d87fb5d11
remove manual fn_decl extraction
2022-12-13 16:29:13 +01:00
akida31
7822822d51
change error message
2022-12-13 16:29:10 +01:00
akida31
b1d7430657
move changes to an extra function
2022-12-13 16:28:34 +01:00
akida31
e326e8c885
Remove hint from help message
2022-12-13 16:28:31 +01:00
akida31
1e5d772417
Improve diagnostic when passing arg to closure and missing borrow.
...
This checks the number of references for the given and expected type and
shows hints to the user if the numbers don't match.
2022-12-13 16:24:38 +01:00
bors
ed620cf969
Auto merge of #105612 - oli-obk:bind_rustdoc, r=GuillaumeGomez
...
use ty::Binder in rustdoc instead of `skip_binder`
r? `@GuillaumeGomez`
this is a preliminary cleanup required to be able to normalize correctly/conveniently in rustdoc
2022-12-13 13:09:40 +00:00
Santiago Pastorino
b22769a7bd
Clarify explicit_predicates_of is_assoc_item_ty comment
2022-12-13 09:41:12 -03:00
Santiago Pastorino
4ae0c5518d
Make InternalSubsts rust docs a bit clearer
2022-12-13 09:28:25 -03:00
Jakob Degen
3522d48112
Don't require owned data in MaybeStorageLive
2022-12-13 04:22:47 -08:00
Deep Majumder
9c8bf51f14
Remove invalid case for mutable borrow suggestion
...
If we have a call such as `foo(&mut buf)` and after reference
collapsing the type is inferred as `&T` where-as the required type is
`&mut T`, don't suggest `foo(&mut mut buf)`. This is wrong syntactically
and the issue lies elsewhere, not in the borrow.
Fixes #105645
2022-12-13 15:57:48 +05:30
Oli Scherer
1f5cb9e50e
Use a label instead of a note for the drop site to create denser diagnostics
2022-12-13 10:08:46 +00:00
Oli Scherer
6984085088
Stop pointing to operators if their libcore method source is not available
2022-12-13 10:06:11 +00:00
Oli Scherer
59554a2b54
Avoid rendering empty annotations
2022-12-13 10:06:08 +00:00
Oli Scherer
2e2a4797a2
Don't emit empty notes
2022-12-13 09:53:36 +00:00
Oli Scherer
063b1675b2
Clarify what "this" means
2022-12-13 09:51:03 +00:00
Oli Scherer
717294fa04
Inform the user which trait is meant in the diagnostic itself instead of relying on the span making it obvious
2022-12-13 09:48:26 +00:00
Oli Scherer
cb26b35b12
Make some diagnostics not depend on the source of what they reference being available
2022-12-13 09:48:22 +00:00
bors
109cccbe4f
Auto merge of #105350 - compiler-errors:faster-binder-relate, r=oli-obk
...
Fast-path some binder relations
A simpler approach than #104598
Fixes #104583
r? types
2022-12-13 07:10:53 +00:00
Michael Goulet
a8a45100a0
Move some codegen-y methods from rustc_hir_analysis::collect -> rustc_codegen_ssa
2022-12-13 05:01:36 +00:00
Michael Goulet
f705d64673
Remove instantiate_type_scheme
2022-12-13 04:56:44 +00:00
Michael Goulet
5dea1d1c6e
EarlyBinder nits
2022-12-13 04:53:36 +00:00
Cassaundra Smith
52a9280fb2
Refine when invalid prefix case error arises
...
Fix cases where the "invalid base prefix for number literal" error arises with
suffixes that look erroneously capitalized but which are in fact invalid.
2022-12-12 19:32:12 -08:00
bors
71ec1457ee
Auto merge of #105436 - nnethercote:inline-place_contents_drop_state_cannot_differ, r=spastorino
...
Inline and remove `place_contents_drop_state_cannot_differ`.
It has a single call site and is hot enough to be worth inlining. And make sure `is_terminal_path` is inlined, too.
r? `@ghost`
2022-12-13 03:28:57 +00:00
Michael Goulet
2025a96ee1
Fast path some binder relations
2022-12-13 03:17:14 +00:00
Gary Guo
d6dc9124b7
Extract shared logic into a new function
2022-12-13 02:34:43 +00:00
Gary Guo
5c58a1b003
Remove unnecessary recursive call to parent unsafeck
...
All bodies are unsafe checked anyway. Current MIR unsafeck also just
returns for closures.
2022-12-13 01:38:38 +00:00
Gary Guo
adf1717219
Ensure valid local_data is set for custom mir building
...
MIR unsafety checking requires this to be valid
2022-12-13 01:38:38 +00:00
Gary Guo
aa5af2a003
Allow unsafe through inline const for THIR unsafety checker
...
The closure handling code is changed slightly to avoid allocation
when THIR building failed.
2022-12-13 01:38:38 +00:00
