Nick Mathewson
65d1f83d2c
Extend [unused_io_amount] to cover AsyncRead and AsyncWrite.
...
Clippy helpfully warns about code like this, telling you that you
probably meant "write_all":
fn say_hi<W:Write>(w: &mut W) {
w.write(b"hello").unwrap();
}
This patch attempts to extend the lint so it also covers this
case:
async fn say_hi<W:AsyncWrite>(w: &mut W) {
w.write(b"hello").await.unwrap();
}
(I've run into this second case several times in my own programming,
and so have my coworkers, so unless we're especially accident-prone
in this area, it's probably worth addressing?)
This patch covers the Async{Read,Write}Ext traits in futures-rs,
and in tokio, since both are quite widely used.
changelog: [`unused_io_amount`] now supports AsyncReadExt and AsyncWriteExt.
2021-12-31 12:10:59 -05:00
Yechan Bae
844996b42e
Consider NonNull as a pointer type
2021-12-03 19:11:40 -05:00
Jason Newcomb
c443f8fb95
Fix strlen_on_c_strings when not used with a full path
2021-11-19 20:02:49 -05:00
Jason Newcomb
2938ffd0d9
Improve heuristics for determining whether eager of lazy evaluation is preferred
2021-11-15 20:54:13 -05:00
surechen
634e79c655
Support suggestion for #7854
...
I think the detection of parking_lot's mutex and rwlock is valuable, so submit this pr, please help judge and review, thank you.
Make let_underscore_lock support parking_lot.
changelog: Make let_underscore_lock support parking_lot
2021-11-15 08:36:36 +08:00
flip1995
085181e29d
Merge remote-tracking branch 'upstream/master' into rustup
2021-10-21 12:18:12 +02:00
Gary Guo
ebf4f03f7d
Remove begin_panic_fmt from clippy
2021-10-19 15:15:59 +01:00
Samuel E. Moelius III
c9599d79a3
Add format_in_format_args and to_string_in_format_args lints
...
Fixes #7667 and #7729
2021-10-15 12:44:38 -04:00
flip1995
5cf4984872
Merge commit 'b7f3f7f6082679da2da9a0b3faf1b5adef3afd3b' into clippyup
2021-10-07 11:21:30 +02:00
flip1995
9613df9c85
Allow invalid-paths for regex paths
2021-10-07 11:12:02 +02:00
Cameron Steffen
e165c12932
Make diangostic item names consistent
2021-10-02 19:38:19 -05:00
flip1995
23d5457e6d
Merge commit 'cb7915b00c235e9b5861564f3be78dba330980ee' into clippyup
2021-09-28 18:03:12 +01:00
Guillaume Gomez
d37f1091e8
Update permissions path for clippy lint
2021-09-13 21:27:53 +02:00
flip1995
091ed44b50
Merge commit '27afd6ade4bb1123a8bf82001629b69d23d62aff' into clippyup
2021-09-08 16:31:47 +02:00
flip1995
2b20f49841
Merge commit '0cce3f643bfcbb92d5a1bb71858c9cbaff749d6b' into clippyup
2021-07-29 12:16:06 +02:00
flip1995
1d084b13a5
Merge commit '54a20a02ecd0e1352a871aa0990bcc8b8b03173e' into clippyup
2021-07-15 10:44:10 +02:00
Felix S. Klock II
b95e1f7b3d
Revert clippy's path to the copy intrinsics (part of reverting PR 81238).
2021-06-04 16:44:28 -04:00
flip1995
d605882023
Merge commit 'b71f3405606d49b9735606b479c3415a0ca9810f' into clippyup
2021-05-06 12:20:44 +02:00
Christiaan Dirkx
ee6d1a35ba
Change std::sys::unix::ext::fs::PermissionsExt::from_mode to std::os: 👿 :unix::fs::PermissionsExt::from_mode in Clippy
2021-05-03 16:56:22 +02:00
flip1995
02bf692169
Merge commit '98e2b9f25b6db4b2680a3d388456d9f95cb28344' into clippyup
2021-04-22 11:31:13 +02:00
flip1995
f6d1f368db
Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup
2021-04-08 17:50:13 +02:00
flip1995
9f6b5de7de
Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup
2021-03-25 19:29:11 +01:00
flip1995
f2f2a005b4
Merge commit '6ed6f1e6a1a8f414ba7e6d9b8222e7e5a1686e42' into clippyup
2021-03-12 15:30:50 +01:00
Cameron Steffen
7984e60d9e
Use diagnostic items in into_iter_collections
2021-03-01 09:04:11 -06:00
flip1995
f64149dd04
Merge commit '928e72dd10749875cbd412f74bfbfd7765dbcd8a' into clippyup
2021-02-25 11:25:22 +01:00
