Fix another case

This commit is contained in:
Esteban Küber
2019-07-23 11:19:13 -07:00
parent 5b3b6b8d00
commit f56c8f6ea4
3 changed files with 72 additions and 3 deletions

View File

@@ -7670,8 +7670,9 @@ impl<'a> Parser<'a> {
let ret = f(self); let ret = f(self);
let last_token = if self.token_cursor.stack.len() == prev { let last_token = if self.token_cursor.stack.len() == prev {
&mut self.token_cursor.frame.last_token &mut self.token_cursor.frame.last_token
} else if self.token_cursor.stack.is_empty() {//&& !self.unclosed_delims.is_empty() { } else if self.token_cursor.stack.get(prev).is_none() {
// This can happen with mismatched delimiters (#62881) // This can happen due to a bad interaction of two unrelated recovery mechanisms with
// mismatched delimiters *and* recovery lookahead on `pub ident(` likely typo (#62881)
return Ok((ret?, TokenStream::new(vec![]))); return Ok((ret?, TokenStream::new(vec![])));
} else { } else {
&mut self.token_cursor.stack[prev].last_token &mut self.token_cursor.stack[prev].last_token
@@ -7680,7 +7681,15 @@ impl<'a> Parser<'a> {
// Pull out the tokens that we've collected from the call to `f` above. // Pull out the tokens that we've collected from the call to `f` above.
let mut collected_tokens = match *last_token { let mut collected_tokens = match *last_token {
LastToken::Collecting(ref mut v) => mem::take(v), LastToken::Collecting(ref mut v) => mem::take(v),
LastToken::Was(_) => panic!("our vector went away?"), LastToken::Was(ref was) => {
let msg = format!("our vector went away? - found Was({:?})", was);
debug!("collect_tokens: {}", msg);
self.sess.span_diagnostic.delay_span_bug(self.token.span, &msg);
// This can happen due to a bad interaction of two unrelated recovery mechanisms
// with mismatched delimiters *and* recovery lookahead on `pub ident(` likely typo
// (#62895, different but similar to the case above)
return Ok((ret?, TokenStream::new(vec![])));
}
}; };
// If we're not at EOF our current token wasn't actually consumed by // If we're not at EOF our current token wasn't actually consumed by

View File

@@ -0,0 +1,11 @@
fn main() {}
fn v() -> isize { //~ ERROR mismatched types
mod _ { //~ ERROR expected identifier
pub fn g() -> isizee { //~ ERROR cannot find type `isizee` in this scope
mod _ { //~ ERROR expected identifier
pub g() -> is //~ ERROR missing `fn` for function definition
(), w20);
}
(), w20); //~ ERROR expected item, found `;`
}

View File

@@ -0,0 +1,49 @@
error: expected identifier, found reserved identifier `_`
--> $DIR/issue-62895.rs:4:5
|
LL | mod _ {
| ^ expected identifier, found reserved identifier
error: expected identifier, found reserved identifier `_`
--> $DIR/issue-62895.rs:6:5
|
LL | mod _ {
| ^ expected identifier, found reserved identifier
error: missing `fn` for function definition
--> $DIR/issue-62895.rs:7:4
|
LL | pub g() -> is
| ^^^^
help: add `fn` here to parse `g` as a public function
|
LL | pub fn g() -> is
| ^^
error: expected item, found `;`
--> $DIR/issue-62895.rs:10:9
|
LL | (), w20);
| ^ help: remove this semicolon
error[E0412]: cannot find type `isizee` in this scope
--> $DIR/issue-62895.rs:5:15
|
LL | pub fn g() -> isizee {
| ^^^^^^ help: a builtin type with a similar name exists: `isize`
error[E0308]: mismatched types
--> $DIR/issue-62895.rs:3:11
|
LL | fn v() -> isize {
| - ^^^^^ expected isize, found ()
| |
| this function's body doesn't return
|
= note: expected type `isize`
found type `()`
error: aborting due to 6 previous errors
Some errors have detailed explanations: E0308, E0412.
For more information about an error, try `rustc --explain E0308`.