rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Document make module design

Browse Source
This commit is contained in:
Aleksey Kladov
2020-12-23 13:01:27 +03:00
parent 85a2875161
commit f00f75a078
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/syntax/src/ast/make.rs
View File

@@ -4,6 +4,11 @@
//! Note that all functions here intended to be stupid constructors, which just //! Note that all functions here intended to be stupid constructors, which just
//! assemble a finish node from immediate children. If you want to do something //! assemble a finish node from immediate children. If you want to do something
//! smarter than that, it probably doesn't belong in this module. //! smarter than that, it probably doesn't belong in this module.
//!
//! Keep in mind that `from_text` functions should be kept private. The public
//! API should require to assemble every node piecewise. The trick of
//! `parse(format!())` we use internally is an implementation detail -- long
//! term, it will be replaced with direct tree manipulation.
use itertools::Itertools; use itertools::Itertools;
use stdx::format_to; use stdx::format_to;
@@ -16,7 +21,8 @@ pub fn name(text: &str) -> ast::Name {
pub fn name_ref(text: &str) -> ast::NameRef { pub fn name_ref(text: &str) -> ast::NameRef {
ast_from_text(&format!("fn f() {{ {}; }}", text)) ast_from_text(&format!("fn f() {{ {}; }}", text))
} }
// FIXME: replace stringly-typed constructor with a family of typed ctors, a-la
// `expr_xxx`.
pub fn ty(text: &str) -> ast::Type { pub fn ty(text: &str) -> ast::Type {
ast_from_text(&format!("impl {} for D {{}};", text)) ast_from_text(&format!("impl {} for D {{}};", text))
} }