rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Don't trigger while_let_on_iterator when the iterator is recreated every iteration

Browse Source
This commit is contained in:
flip1995
2020-04-25 20:51:02 +02:00
parent 6ffe725bbc
commit eadd9d24dc
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
clippy_lints/src/loops.rs
View File

@@ -566,6 +566,17 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Loops {
) = (pat, &match_expr.kind) ) = (pat, &match_expr.kind)
{ {
let iter_expr = &method_args[0]; let iter_expr = &method_args[0];
// Don't lint when the iterator is recreated on every iteration
if_chain! {
if let ExprKind::MethodCall(..) | ExprKind::Call(..) = iter_expr.kind;
if let Some(iter_def_id) = get_trait_def_id(cx, &paths::ITERATOR);
if implements_trait(cx, cx.tables.expr_ty(iter_expr), iter_def_id, &[]);
then {
return;
}
}
let lhs_constructor = last_path_segment(qpath); let lhs_constructor = last_path_segment(qpath);
if method_path.ident.name == sym!(next) if method_path.ident.name == sym!(next)
&& match_trait_method(cx, match_expr, &paths::ITERATOR) && match_trait_method(cx, match_expr, &paths::ITERATOR)