rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

re-stabilize the AVX-512 features that were stabilized in Rust 1.27.0 (#842)

Browse Source 
* re-stabilize the AVX-512 features that were stabilized in Rust 1.27.0

https://github.com/rust-lang/stdarch/pull/739 added per-feature
stabilization of runtime CPU feature detection. In so doing, it
de-stabilized some detection features that had been stable since Rust
1.27.0, breaking some published crates (on nightly). This commit
re-stabilizes the subset of AVX-512 detection features that were
included in 1.27.0 (that is, the pre-Ice-Lake subset). Other instruction
sets (MMX in particular) remain de-stabilized, pending a decision about
whether should ever stabilize them.

See https://github.com/rust-lang/rust/issues/68905.

* add a comment explaining feature detection stability

* adjust stabilizations to match most recent proposal

https://github.com/rust-lang/rust/issues/68905#issuecomment-595376319
This commit is contained in:
Jack O'Connor
2020-03-19 10:29:50 -04:00
committed by GitHub
parent 9ab5dc0873
commit e367bcd7f9
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
library/stdarch/crates/std_detect/src/detect/arch/x86.rs
View File

@@ -92,7 +92,7 @@ features! {
/// RDSEED /// RDSEED
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] tsc: "tsc"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] tsc: "tsc";
/// TSC (Time Stamp Counter) /// TSC (Time Stamp Counter)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] mmx: "mmx"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] mmx: "mmx";
/// MMX (MultiMedia eXtensions) /// MMX (MultiMedia eXtensions)
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] sse: "sse"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] sse: "sse";
/// SSE (Streaming SIMD Extensions) /// SSE (Streaming SIMD Extensions)
@@ -106,7 +106,7 @@ features! {
/// SSE4.1 (Streaming SIMD Extensions 4.1) /// SSE4.1 (Streaming SIMD Extensions 4.1)
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] sse4_2: "sse4.2"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] sse4_2: "sse4.2";
/// SSE4.2 (Streaming SIMD Extensions 4.2) /// SSE4.2 (Streaming SIMD Extensions 4.2)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] sse4a: "sse4a"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] sse4a: "sse4a";
/// SSE4a (Streaming SIMD Extensions 4a) /// SSE4a (Streaming SIMD Extensions 4a)
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] sha: "sha"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] sha: "sha";
/// SHA /// SHA
@@ -114,19 +114,23 @@ features! {
/// AVX (Advanced Vector Extensions) /// AVX (Advanced Vector Extensions)
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx2: "avx2"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx2: "avx2";
/// AVX2 (Advanced Vector Extensions 2) /// AVX2 (Advanced Vector Extensions 2)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] avx512f: "avx512f" ; // Detection for the AVX-512 features below was accidentally stabilized in
// Rust 1.27.0, even though the corresponding intrinsics are still unstable
// or unimplemeted. There are stable callers who rely on detection support,
// e.g. to call AVX-512 C code via FFI.
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512f: "avx512f" ;
/// AVX-512 F (Foundation) /// AVX-512 F (Foundation)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] avx512cd: "avx512cd" ; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512cd: "avx512cd" ;
/// AVX-512 CD (Conflict Detection Instructions) /// AVX-512 CD (Conflict Detection Instructions)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] avx512er: "avx512er"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512er: "avx512er";
/// AVX-512 ER (Expo nential and Reciprocal Instructions) /// AVX-512 ER (Expo nential and Reciprocal Instructions)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] avx512pf: "avx512pf"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512pf: "avx512pf";
/// AVX-512 PF (Prefetch Instructions) /// AVX-512 PF (Prefetch Instructions)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] avx512bw: "avx512bw"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512bw: "avx512bw";
/// AVX-512 BW (Byte and Word Instructions) /// AVX-512 BW (Byte and Word Instructions)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] avx512dq: "avx512dq"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512dq: "avx512dq";
/// AVX-512 DQ (Doubleword and Quadword) /// AVX-512 DQ (Doubleword and Quadword)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] avx512vl: "avx512vl"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] avx512vl: "avx512vl";
/// AVX-512 VL (Vector Length Extensions) /// AVX-512 VL (Vector Length Extensions)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] avx512ifma: "avx512ifma"; @FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] avx512ifma: "avx512ifma";
/// AVX-512 IFMA (Integer Fused Multiply Add) /// AVX-512 IFMA (Integer Fused Multiply Add)
@@ -161,7 +165,7 @@ features! {
/// BMI2 (Bit Manipulation Instructions 2) /// BMI2 (Bit Manipulation Instructions 2)
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] lzcnt: "lzcnt"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] lzcnt: "lzcnt";
/// ABM (Advanced Bit Manipulation) / LZCNT (Leading Zero Count) /// ABM (Advanced Bit Manipulation) / LZCNT (Leading Zero Count)
@FEATURE: #[unstable(feature = "stdsimd", issue = "27731")] tbm: "tbm"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] tbm: "tbm";
/// TBM (Trailing Bit Manipulation) /// TBM (Trailing Bit Manipulation)
@FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] popcnt: "popcnt"; @FEATURE: #[stable(feature = "simd_x86", since = "1.27.0")] popcnt: "popcnt";
/// POPCNT (Population Count) /// POPCNT (Population Count)