rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove DropNodeKey::kind.

Browse Source 
It's not needed, because `next` and `local` fields uniquely identify the
drop. This is a ~2% speed win on the very large program in #134404, and
it's also a tiny bit simpler.
This commit is contained in:
Nicholas Nethercote
2025-05-20 16:39:59 +10:00
parent 283db70ace
commit df09feddfa
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compiler/rustc_mir_build/src/builder/scope.rs
View File

@@ -230,7 +230,6 @@ struct DropNode {
struct DropNodeKey { struct DropNodeKey {
next: DropIdx, next: DropIdx,
local: Local, local: Local,
kind: DropKind,
} }
impl Scope { impl Scope {
@@ -291,7 +290,7 @@ impl DropTree {
let drops = &mut self.drops; let drops = &mut self.drops;
*self *self
.existing_drops_map .existing_drops_map
.entry(DropNodeKey { next, local: data.local, kind: data.kind }) .entry(DropNodeKey { next, local: data.local })
// Create a new node, and also add its index to the map. // Create a new node, and also add its index to the map.
.or_insert_with(|| drops.push(DropNode { data, next })) .or_insert_with(|| drops.push(DropNode { data, next }))
} }