Delete spaces
This commit is contained in:
@@ -342,7 +342,7 @@ We have prioritization labels and a sync-blocker label, which are described belo
|
|||||||
- [P-low][p-low]: Requires attention (fix/response/evaluation) by a team member but isn't urgent.
|
- [P-low][p-low]: Requires attention (fix/response/evaluation) by a team member but isn't urgent.
|
||||||
- [P-medium][p-medium]: Should be addressed by a team member until the next sync.
|
- [P-medium][p-medium]: Should be addressed by a team member until the next sync.
|
||||||
- [P-high][p-high]: Should be immediately addressed and will require an out-of-cycle sync or a backport.
|
- [P-high][p-high]: Should be immediately addressed and will require an out-of-cycle sync or a backport.
|
||||||
- [L-sync-blocker][l-sync-blocker]: An issue that "blocks" a sync.
|
- [L-sync-blocker][l-sync-blocker]: An issue that "blocks" a sync.
|
||||||
Or rather: before the sync this should be addressed,
|
Or rather: before the sync this should be addressed,
|
||||||
e.g. by removing a lint again, so it doesn't hit beta/stable.
|
e.g. by removing a lint again, so it doesn't hit beta/stable.
|
||||||
|
|
||||||
|
|||||||
@@ -95,7 +95,7 @@ As with `cargo check`, this includes dependencies that are members of the worksp
|
|||||||
If you want to run Clippy **only** on the given crate, use the `--no-deps` option like this:
|
If you want to run Clippy **only** on the given crate, use the `--no-deps` option like this:
|
||||||
|
|
||||||
```terminal
|
```terminal
|
||||||
cargo clippy -p example -- --no-deps
|
cargo clippy -p example -- --no-deps
|
||||||
```
|
```
|
||||||
|
|
||||||
### As a rustc replacement (`clippy-driver`)
|
### As a rustc replacement (`clippy-driver`)
|
||||||
|
|||||||
@@ -178,7 +178,7 @@ pub fn eq_expr(l: &Expr, r: &Expr) -> bool {
|
|||||||
(Path(lq, lp), Path(rq, rp)) => both(lq, rq, |l, r| eq_qself(l, r)) && eq_path(lp, rp),
|
(Path(lq, lp), Path(rq, rp)) => both(lq, rq, |l, r| eq_qself(l, r)) && eq_path(lp, rp),
|
||||||
(MacCall(l), MacCall(r)) => eq_mac_call(l, r),
|
(MacCall(l), MacCall(r)) => eq_mac_call(l, r),
|
||||||
(Struct(lse), Struct(rse)) => {
|
(Struct(lse), Struct(rse)) => {
|
||||||
eq_maybe_qself(&lse.qself, &rse.qself)
|
eq_maybe_qself(&lse.qself, &rse.qself)
|
||||||
&& eq_path(&lse.path, &rse.path)
|
&& eq_path(&lse.path, &rse.path)
|
||||||
&& eq_struct_rest(&lse.rest, &rse.rest)
|
&& eq_struct_rest(&lse.rest, &rse.rest)
|
||||||
&& unordered_over(&lse.fields, &rse.fields, |l, r| eq_field(l, r))
|
&& unordered_over(&lse.fields, &rse.fields, |l, r| eq_field(l, r))
|
||||||
|
|||||||
@@ -96,9 +96,9 @@ cargo dev ide_setup
|
|||||||
|
|
||||||
## lintcheck
|
## lintcheck
|
||||||
`cargo lintcheck` will build and run clippy on a fixed set of crates and generate a log of the results.
|
`cargo lintcheck` will build and run clippy on a fixed set of crates and generate a log of the results.
|
||||||
You can `git diff` the updated log against its previous version and
|
You can `git diff` the updated log against its previous version and
|
||||||
see what impact your lint made on a small set of crates.
|
see what impact your lint made on a small set of crates.
|
||||||
If you add a new lint, please audit the resulting warnings and make sure
|
If you add a new lint, please audit the resulting warnings and make sure
|
||||||
there are no false positives and that the suggestions are valid.
|
there are no false positives and that the suggestions are valid.
|
||||||
|
|
||||||
Refer to the tools [README] for more details.
|
Refer to the tools [README] for more details.
|
||||||
|
|||||||
@@ -73,5 +73,5 @@ You can run `./lintcheck/target/debug/lintcheck --fix` which will run Clippy wit
|
|||||||
print a warning if Clippys suggestions fail to apply (if the resulting code does not build).
|
print a warning if Clippys suggestions fail to apply (if the resulting code does not build).
|
||||||
This lets us spot bad suggestions or false positives automatically in some cases.
|
This lets us spot bad suggestions or false positives automatically in some cases.
|
||||||
|
|
||||||
Please note that the target dir should be cleaned afterwards since clippy will modify
|
Please note that the target dir should be cleaned afterwards since clippy will modify
|
||||||
the downloaded sources which can lead to unexpected results when running lintcheck again afterwards.
|
the downloaded sources which can lead to unexpected results when running lintcheck again afterwards.
|
||||||
|
|||||||
@@ -363,7 +363,7 @@
|
|||||||
|
|
||||||
$scope.bySearch = function (lint, index, array) {
|
$scope.bySearch = function (lint, index, array) {
|
||||||
let searchStr = $scope.search;
|
let searchStr = $scope.search;
|
||||||
// It can be `null` I haven't missed this value
|
// It can be `null` I haven't missed this value
|
||||||
if (searchStr == null || searchStr.length < 3) {
|
if (searchStr == null || searchStr.length < 3) {
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
@@ -375,7 +375,7 @@
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Search the description
|
// Search the description
|
||||||
// The use of `for`-loops instead of `foreach` enables us to return early
|
// The use of `for`-loops instead of `foreach` enables us to return early
|
||||||
let terms = searchStr.split(" ");
|
let terms = searchStr.split(" ");
|
||||||
for (index = 0; index < terms.length; index++) {
|
for (index = 0; index < terms.length; index++) {
|
||||||
if (lint.id.indexOf(terms[index]) !== -1) {
|
if (lint.id.indexOf(terms[index]) !== -1) {
|
||||||
@@ -463,7 +463,7 @@
|
|||||||
|
|
||||||
let children = themeMenu.children;
|
let children = themeMenu.children;
|
||||||
for (let index = 0; index < children.length; index++) {
|
for (let index = 0; index < children.length; index++) {
|
||||||
let child = children[index];
|
let child = children[index];
|
||||||
child.addEventListener("click", function(e) {
|
child.addEventListener("click", function(e) {
|
||||||
setTheme(child.id, true);
|
setTheme(child.id, true);
|
||||||
});
|
});
|
||||||
@@ -476,7 +476,7 @@
|
|||||||
let enableHighlight = false;
|
let enableHighlight = false;
|
||||||
let enableNight = false;
|
let enableNight = false;
|
||||||
let enableAyu = false;
|
let enableAyu = false;
|
||||||
|
|
||||||
if (theme == "ayu") {
|
if (theme == "ayu") {
|
||||||
enableAyu = true;
|
enableAyu = true;
|
||||||
} else if (theme == "coal" || theme == "navy") {
|
} else if (theme == "coal" || theme == "navy") {
|
||||||
|
|||||||
Reference in New Issue
Block a user