rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

rustdoc: Set a nonzero exit status on failure

Browse Source 
Now that rustdoc is spawning a child task, the program won't exit with a default
error code if the main task fails (because it never fails). This commit forces
the main task to wait for a child task in order to correctly propagate failure.

Closes #16341
This commit is contained in:
Alex Crichton
2014-08-07 19:38:18 -07:00
parent 8888d7c8e9
commit d9038fc3b3
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/librustdoc/lib.rs
View File

@@ -120,9 +120,16 @@ pub fn main() {
// So, in summary, it is unknown why this is necessary, what it is // So, in summary, it is unknown why this is necessary, what it is
// preventing, or what the actual bug is. In the meantime, this allows // preventing, or what the actual bug is. In the meantime, this allows
// --test to work on windows, which seems good, right? Fun times. // --test to work on windows, which seems good, right? Fun times.
let (tx, rx) = channel();
spawn(proc() { spawn(proc() {
std::os::set_exit_status(main_args(std::os::args().as_slice())); std::os::set_exit_status(main_args(std::os::args().as_slice()));
tx.send(());
}); });
// If the task failed, set an error'd exit status
if rx.recv_opt().is_err() {
std::os::set_exit_status(std::rt::DEFAULT_ERROR_CODE);
}
} }
pub fn opts() -> Vec<getopts::OptGroup> { pub fn opts() -> Vec<getopts::OptGroup> {