rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Explain the discrepancy in the mask type for _mm_shuffle_ps (#879)

Browse Source
This commit is contained in:
Georgio Nicolas
2020-08-01 16:35:03 +03:00
committed by GitHub
parent 9a3b159e83
commit d7660eb8d5
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
library/stdarch/crates/core_arch/src/x86/sse.rs
View File

@@ -992,6 +992,12 @@ pub const fn _MM_SHUFFLE(z: u32, y: u32, x: u32, w: u32) -> i32 {
/// `b`. Mask is split to 2 control bits each to index the element from inputs. /// `b`. Mask is split to 2 control bits each to index the element from inputs.
/// ///
/// [Intel's documentation](https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_shuffle_ps) /// [Intel's documentation](https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_shuffle_ps)
///
/// Note that there appears to be a mistake within Intel's Intrinsics Guide.
/// `_mm_shuffle_ps` is supposed to take an `i32` instead of an `u32`
/// as is the case for [other shuffle intrinsics](https://software.intel.com/sites/landingpage/IntrinsicsGuide/#text=_mm_shuffle_).
/// Performing an implicit type conversion between an unsigned integer and a signed integer
/// does not cause a problem in C, however Rust's commitment to strong typing does not allow this.
#[inline] #[inline]
#[target_feature(enable = "sse")] #[target_feature(enable = "sse")]
#[cfg_attr(test, assert_instr(shufps, mask = 3))] #[cfg_attr(test, assert_instr(shufps, mask = 3))]