rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Check method calls

Browse Source
This commit is contained in:
Zaki Manian
2017-09-02 14:19:45 -07:00
parent 2a97aadacf
commit d6d78cdbbe
1 changed files with 25 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
clippy_lints/src/is_unit_expr.rs
View File

@@ -46,12 +46,31 @@ impl EarlyLintPass for UnitExpr {
) )
} }
} }
// if let ExprKind::MethodCall(ref path, ref args) = expr.node { if let ExprKind::MethodCall(_, ref args) = expr.node {
// unimplemented!(); for ref arg in args{
// } if is_unit_expr(arg){
// if let ExprKind::Call(ref path, ref args) = expr.node{ span_lint_and_sugg(
// unimplemented!(); cx,
// } UNIT_EXPR,
arg.span,
"trailing semicolons can be tricky",
"remove the last semicolon",
"TODO".to_owned()
)
} }
}
if let ExprKind::Call( _, ref args) = expr.node{
for ref arg in args{
if is_unit_expr(arg){
span_lint_and_sugg(
cx,
UNIT_EXPR,
arg.span,
"trailing semicolons can be tricky",
"remove the last semicolon",
"TODO".to_owned()
)
} } }
} }
fn check_stmt(&mut self, cx: &EarlyContext, stmt: &Stmt) { fn check_stmt(&mut self, cx: &EarlyContext, stmt: &Stmt) {