rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Made error output the contents of Cargo's stderr as well.

Browse Source
This commit is contained in:
Cadu
2022-04-04 19:14:33 -03:00
parent 8e5c57f050
commit ca9718aa42
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/flycheck/src/lib.rs
View File

@@ -2,7 +2,7 @@
//! another compatible command (f.x. clippy) in a background thread and provide //! another compatible command (f.x. clippy) in a background thread and provide
//! LSP diagnostics based on the output of the command. //! LSP diagnostics based on the output of the command.
use std::{fmt, io, process::Command, time::Duration}; use std::{fmt, io, process::Command, time::Duration, str::from_utf8};
use crossbeam_channel::{never, select, unbounded, Receiver, Sender}; use crossbeam_channel::{never, select, unbounded, Receiver, Sender};
use paths::AbsPathBuf; use paths::AbsPathBuf;
@@ -329,8 +329,8 @@ impl CargoActor {
Ok(output) if output.status.success() => Ok(()), Ok(output) if output.status.success() => Ok(()),
Ok(output) => { Ok(output) => {
Err(io::Error::new(io::ErrorKind::Other, format!( Err(io::Error::new(io::ErrorKind::Other, format!(
"Cargo watcher failed, the command produced no valid metadata (exit code: {:?})\nMake sure you have `cargo clippy` installed and updated.", "Cargo watcher failed, the command produced no valid metadata (exit code: {:?})\nCargo's stderr output:\n{}",
output.status output.status, from_utf8(&output.stderr).unwrap_or("(Error: Could not fetch Cargo's stderr output)")
))) )))
} }
Err(e) => Err(io::Error::new(e.kind(), format!("{:?}: {}", e, error))), Err(e) => Err(io::Error::new(e.kind(), format!("{:?}: {}", e, error))),