rustdoc: Fix some minor issues per reviewer

This commit is contained in:
Vitaly _Vi Shukela
2018-01-31 17:35:57 +03:00
parent 7cd0280226
commit c904b1bef4
4 changed files with 22 additions and 25 deletions

View File

@@ -1661,18 +1661,18 @@
} }
if (hasClass(relatedDoc, "docblock")) { if (hasClass(relatedDoc, "docblock")) {
var action = mode; var action = mode;
if (action == "toggle") { if (action === "toggle") {
if(hasClass(relatedDoc, "hidden-by-usual-hider")) { if (hasClass(relatedDoc, "hidden-by-usual-hider")) {
action="show"; action = "show";
} else { } else {
action="hide"; action = "hide";
} }
} }
if (action == "hide") { if (action === "hide") {
addClass(relatedDoc, "hidden-by-usual-hider"); addClass(relatedDoc, "hidden-by-usual-hider");
onEach(toggle.childNodes, adjustToggle(true)); onEach(toggle.childNodes, adjustToggle(true));
addClass(toggle.parentNode, 'collapsed'); addClass(toggle.parentNode, 'collapsed');
} else if (action == "show") { } else if (action === "show") {
removeClass(relatedDoc, "hidden-by-usual-hider"); removeClass(relatedDoc, "hidden-by-usual-hider");
removeClass(toggle.parentNode, 'collapsed'); removeClass(toggle.parentNode, 'collapsed');
onEach(toggle.childNodes, adjustToggle(false)); onEach(toggle.childNodes, adjustToggle(false));
@@ -1682,14 +1682,14 @@
// we are collapsing the impl block // we are collapsing the impl block
function implHider(addOrRemove) { function implHider(addOrRemove) {
return function(n) { return function(n) {
if(hasClass(n, "method")) { if (hasClass(n, "method")) {
if (addOrRemove) { if (addOrRemove) {
addClass(n, "hidden-by-impl-hider"); addClass(n, "hidden-by-impl-hider");
} else { } else {
removeClass(n, "hidden-by-impl-hider"); removeClass(n, "hidden-by-impl-hider");
} }
var ns = n.nextElementSibling; var ns = n.nextElementSibling;
while(true) { while (true) {
if (ns && ( if (ns && (
hasClass(ns, "docblock") || hasClass(ns, "docblock") ||
hasClass(ns, "stability") || hasClass(ns, "stability") ||
@@ -1715,24 +1715,26 @@
relatedDoc = relatedDoc.nextElementSibling; relatedDoc = relatedDoc.nextElementSibling;
} }
if (!relatedDoc) return; if (!relatedDoc) {
return;
}
// Hide all functions, but not associated types/consts // Hide all functions, but not associated types/consts
var action = mode; var action = mode;
if (action == "toggle") { if (action === "toggle") {
if(hasClass(relatedDoc, "fns-now-collapsed")) { if (hasClass(relatedDoc, "fns-now-collapsed")) {
action="show"; action = "show";
} else { } else {
action="hide"; action = "hide";
} }
} }
if(action == "show") { if (action === "show") {
removeClass(relatedDoc, "fns-now-collapsed"); removeClass(relatedDoc, "fns-now-collapsed");
onEach(toggle.childNodes, adjustToggle(false)); onEach(toggle.childNodes, adjustToggle(false));
onEach(relatedDoc.childNodes, implHider(false)); onEach(relatedDoc.childNodes, implHider(false));
} else if (action == "hide") { } else if (action === "hide") {
addClass(relatedDoc, "fns-now-collapsed"); addClass(relatedDoc, "fns-now-collapsed");
onEach(toggle.childNodes, adjustToggle(true)); onEach(toggle.childNodes, adjustToggle(true));
onEach(relatedDoc.childNodes, implHider(true)); onEach(relatedDoc.childNodes, implHider(true));

View File

@@ -1189,3 +1189,8 @@ kbd {
z-index: 1; z-index: 1;
} }
} }
.hidden-by-impl-hider,
.hidden-by-usual-hider {
display: none;
}

View File

@@ -386,8 +386,3 @@ kbd {
background: #353535; background: #353535;
} }
} }
.hidden-by-impl-hider,
.hidden-by-usual-hider {
display: none;
}

View File

@@ -383,8 +383,3 @@ kbd {
background: #fff; background: #fff;
} }
} }
.hidden-by-impl-hider,
.hidden-by-usual-hider {
display: none;
}