rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Comments only: annotate FIXMEs

Browse Source
This commit is contained in:
Tim Chevalier
2012-06-21 14:17:54 -07:00
parent be8b09160b
commit c814df0bd6
8 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/rt/rust_builtin.cpp
View File

@@ -233,7 +233,7 @@ rand_free(randctx *rctx) {
/* Debug helpers strictly to verify ABI conformance.
*
* FIXME: move these into a testcase when the testsuite
* understands how to have explicit C files included.
* understands how to have explicit C files included. (#2688)
*/
struct quad {
@@ -289,17 +289,18 @@ debug_opaque(type_desc *t, uint8_t *front) {
LOG(task, stdlib, "debug_opaque");
debug_tydesc_helper(t);
// FIXME may want to actually account for alignment. `front` may not
// indeed be the front byte of the passed-in argument.
// indeed be the front byte of the passed-in argument. (#2667)
for (uintptr_t i = 0; i < t->size; ++front, ++i) {
LOG(task, stdlib, " byte %" PRIdPTR ": 0x%" PRIx8, i, *front);
}
}
// FIXME this no longer reflects the actual structure of boxes!
// FIXME this no longer reflects the actual structure of boxes! (#2667)
struct rust_box {
RUST_REFCOUNTED(rust_box)
// FIXME `data` could be aligned differently from the actual box body data
// (#2667)
uint8_t data[];
};
@@ -635,7 +636,7 @@ extern "C" CDECL rust_task*
rust_new_task_in_sched(rust_sched_id id) {
rust_task *task = rust_get_current_task();
rust_scheduler *sched = task->kernel->get_scheduler_by_id(id);
// FIXME: What if we didn't get the scheduler?
// FIXME: What if we didn't get the scheduler? (#2668)
return new_task_common(sched, task);
}