rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Simplify creation of span_replace_word

Browse Source 
Part of unwrap_or test
This commit is contained in:
bootandy
2018-02-20 12:38:20 -05:00
parent f3d1a0cec2
commit c708154c16
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
clippy_lints/src/methods.rs
View File

@@ -913,9 +913,7 @@ fn lint_or_fun_call(cx: &LateContext, expr: &hir::Expr, name: &str, args: &[hir:
return; return;
} }
let start_point = self_expr.span.hi(); let span_replace_word = self_expr.span.with_lo(span.hi());
let end_point = span.hi();
let span_replace_word = Span::new(start_point, end_point, span.ctxt());
// don't lint for constant values // don't lint for constant values
let owner_def = cx.tcx.hir.get_parent_did(arg.id); let owner_def = cx.tcx.hir.get_parent_did(arg.id);
@@ -946,7 +944,7 @@ fn lint_or_fun_call(cx: &LateContext, expr: &hir::Expr, name: &str, args: &[hir:
span_lint_and_sugg( span_lint_and_sugg(
cx, cx,
OR_FUN_CALL, OR_FUN_CALL,
span_replace_word , span_replace_word,
&format!("use of `{}` followed by a function call", name), &format!("use of `{}` followed by a function call", name),
"try this", "try this",
format!(".{}_{}({})", name, suffix, sugg), format!(".{}_{}({})", name, suffix, sugg),