Split out termination_trait_test feature gate
This commit is contained in:
@@ -432,6 +432,9 @@ declare_features! (
|
||||
// Termination trait in main (RFC 1937)
|
||||
(active, termination_trait, "1.24.0", Some(43301), None),
|
||||
|
||||
// Termination trait in tests (RFC 1937)
|
||||
(active, termination_trait_test, "1.24.0", Some(48854), None),
|
||||
|
||||
// Allows use of the :lifetime macro fragment specifier
|
||||
(active, macro_lifetime_matcher, "1.24.0", Some(46895), None),
|
||||
|
||||
|
||||
@@ -332,7 +332,7 @@ fn is_test_fn(cx: &TestCtxt, i: &ast::Item) -> bool {
|
||||
ast::ItemKind::Fn(ref decl, _, _, _, ref generics, _) => {
|
||||
// If the termination trait is active, the compiler will check that the output
|
||||
// type implements the `Termination` trait as `libtest` enforces that.
|
||||
let output_matches = if cx.features.termination_trait {
|
||||
let output_matches = if cx.features.termination_trait_test {
|
||||
true
|
||||
} else {
|
||||
let no_output = match decl.output {
|
||||
@@ -359,7 +359,7 @@ fn is_test_fn(cx: &TestCtxt, i: &ast::Item) -> bool {
|
||||
match has_test_signature(cx, i) {
|
||||
Yes => true,
|
||||
No => {
|
||||
if cx.features.termination_trait {
|
||||
if cx.features.termination_trait_test {
|
||||
diag.span_err(i.span, "functions used as tests can not have any arguments");
|
||||
} else {
|
||||
diag.span_err(i.span, "functions used as tests must have signature fn() -> ()");
|
||||
@@ -388,7 +388,7 @@ fn is_bench_fn(cx: &TestCtxt, i: &ast::Item) -> bool {
|
||||
|
||||
// If the termination trait is active, the compiler will check that the output
|
||||
// type implements the `Termination` trait as `libtest` enforces that.
|
||||
let output_matches = if cx.features.termination_trait {
|
||||
let output_matches = if cx.features.termination_trait_test {
|
||||
true
|
||||
} else {
|
||||
let no_output = match decl.output {
|
||||
@@ -416,7 +416,7 @@ fn is_bench_fn(cx: &TestCtxt, i: &ast::Item) -> bool {
|
||||
if has_bench_attr && !has_bench_signature {
|
||||
let diag = cx.span_diagnostic;
|
||||
|
||||
if cx.features.termination_trait {
|
||||
if cx.features.termination_trait_test {
|
||||
diag.span_err(i.span, "functions used as benches must have signature \
|
||||
`fn(&mut Bencher) -> impl Termination`");
|
||||
} else {
|
||||
|
||||
22
src/test/compile-fail/feature-gate-termination_trait_test.rs
Normal file
22
src/test/compile-fail/feature-gate-termination_trait_test.rs
Normal file
@@ -0,0 +1,22 @@
|
||||
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
|
||||
// file at the top-level directory of this distribution and at
|
||||
// http://rust-lang.org/COPYRIGHT.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
// option. This file may not be copied, modified, or distributed
|
||||
// except according to those terms.
|
||||
|
||||
// compile-flags: --test
|
||||
|
||||
fn main() {}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
#[test]
|
||||
fn it_works() -> Result<(), ()> {
|
||||
//~^ ERROR functions used as tests must have signature fn() -> ()
|
||||
Ok(())
|
||||
}
|
||||
}
|
||||
@@ -10,7 +10,7 @@
|
||||
|
||||
// compile-flags: --test
|
||||
|
||||
#![feature(termination_trait)]
|
||||
#![feature(termination_trait_test)]
|
||||
#![feature(test)]
|
||||
|
||||
extern crate test;
|
||||
|
||||
Reference in New Issue
Block a user