rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Emit warning while outputs is not exe and prints linkage info

Browse Source 
Signed-off-by: xizheyin <xizheyin@smail.nju.edu.cn>
This commit is contained in:
xizheyin
2025-03-07 10:13:30 +08:00
parent 6e23095adf
commit c59b70841c
6 changed files with 38 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
compiler/rustc_codegen_ssa/src/back/link.rs
View File

@@ -68,6 +68,23 @@ pub fn ensure_removed(dcx: DiagCtxtHandle<'_>, path: &Path) {
} }
} }
fn check_link_info_print_request(sess: &Session, crate_type: CrateType) {
let print_native_static_libs =
sess.opts.prints.iter().any(|p| p.kind == PrintKind::NativeStaticLibs);
if print_native_static_libs {
if crate_type != CrateType::Staticlib {
sess.dcx()
.warn(format!("cannot output linkage information without staticlib crate-type"));
sess.dcx()
.note(format!("consider `--crate-type staticlib` to print linkage information"));
} else if !sess.opts.output_types.should_link() {
sess.dcx().warn(format!(
"skipping link step due to conflict: cannot output linkage information without emitting link"
));
}
}
}
/// Performs the linkage portion of the compilation phase. This will generate all /// Performs the linkage portion of the compilation phase. This will generate all
/// of the requested outputs for this compilation session. /// of the requested outputs for this compilation session.
pub fn link_binary( pub fn link_binary(
@@ -178,6 +195,8 @@ pub fn link_binary(
tempfiles_for_stdout_output.push(out_filename); tempfiles_for_stdout_output.push(out_filename);
} }
} }
check_link_info_print_request(sess, crate_type);
} }
// Remove the temporary object file and metadata if we aren't saving temps. // Remove the temporary object file and metadata if we aren't saving temps.

5
tests/ui/print-request/emit-warning-print-link-info-without-staticlib.rs Normal file
View File

@@ -0,0 +1,5 @@
//@ compile-flags: --print native-static-libs
//@ check-pass
//~? WARN cannot output linkage information without staticlib crate-type
fn main() {}

6
tests/ui/print-request/emit-warning-print-link-info-without-staticlib.stderr Normal file
View File

@@ -0,0 +1,6 @@
warning: cannot output linkage information without staticlib crate-type
note: consider `--crate-type staticlib` to print linkage information
warning: 1 warning emitted

3
tests/ui/print-request/emit-warning-while-exe-and-print-link-info.rs Normal file
View File

@@ -0,0 +1,3 @@
//@ compile-flags: --print native-static-libs --crate-type staticlib --emit metadata
//@ check-pass
//~? WARN skipping link step due to conflict: cannot output linkage information without emitting link

4
tests/ui/print-request/emit-warning-while-exe-and-print-link-info.stderr Normal file
View File

@@ -0,0 +1,4 @@
warning: skipping link step due to conflict: cannot output linkage information without emitting link
warning: 1 warning emitted

1
tests/ui/print-request/stability.rs
View File

@@ -110,3 +110,4 @@ fn main() {}
//[check_cfg]~? ERROR the `-Z unstable-options` flag must also be passed to enable the `check-cfg` print option //[check_cfg]~? ERROR the `-Z unstable-options` flag must also be passed to enable the `check-cfg` print option
//[supported_crate_types]~? ERROR the `-Z unstable-options` flag must also be passed to enable the `supported-crate-types` print option //[supported_crate_types]~? ERROR the `-Z unstable-options` flag must also be passed to enable the `supported-crate-types` print option
//[target_spec_json]~? ERROR the `-Z unstable-options` flag must also be passed to enable the `target-spec-json` print option //[target_spec_json]~? ERROR the `-Z unstable-options` flag must also be passed to enable the `target-spec-json` print option
//[native_static_libs]~? WARNING cannot output linkage information without staticlib crate-type