rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Put the OS error in the error string in io::mk_file_writer()

Browse Source
This commit is contained in:
Tim Chevalier
2012-03-15 20:44:47 -07:00
parent e464e2ba56
commit c1c84e92dd
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libcore/io.rs
View File

@@ -398,9 +398,7 @@ fn mk_file_writer(path: str, flags: [fileflag])
(S_IRUSR | S_IWUSR) as c_int) (S_IRUSR | S_IWUSR) as c_int)
}; };
if fd < (0 as c_int) { if fd < (0 as c_int) {
// FIXME don't log this! put it in the returned error string result::err(#fmt("error opening %s: %s", path, sys::last_os_error()))
log(error, sys::last_os_error());
result::err("error opening " + path)
} else { } else {
result::ok(fd_writer(fd, true)) result::ok(fd_writer(fd, true))
} }
@@ -748,7 +746,7 @@ mod tests {
fn file_writer_bad_name() { fn file_writer_bad_name() {
alt io::file_writer("?/?", []) { alt io::file_writer("?/?", []) {
result::err(e) { result::err(e) {
assert e == "error opening ?/?"; assert e == "error opening ?/?: No such file or directory";
} }
result::ok(_) { fail; } result::ok(_) { fail; }
} }