rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Use an error struct instead of a panic

Browse Source
This commit is contained in:
Alice Ryhl
2024-05-15 10:01:55 +02:00
parent 518becf5ea
commit b780fa9219
10 changed files with 47 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
compiler/rustc_codegen_llvm/src/llvm_util.rs
View File

@@ -1,6 +1,6 @@
use crate::back::write::create_informational_target_machine;
use crate::errors::{
InvalidTargetFeaturePrefix, PossibleFeature, TargetFeatureDisableOrEnable,
FixedX18InvalidArch, InvalidTargetFeaturePrefix, PossibleFeature, TargetFeatureDisableOrEnable,
UnknownCTargetFeature, UnknownCTargetFeaturePrefix, UnstableCTargetFeature,
};
use crate::llvm;
@@ -618,11 +618,10 @@ pub(crate) fn global_llvm_features(sess: &Session, diagnostics: bool) -> Vec<Str
// -Zfixed-x18
if sess.opts.unstable_opts.fixed_x18 {
if sess.target.arch != "aarch64" {
// TODO: What's the correct way to return a error here?
panic!("-Zfixed-x18 only allowed on aarch64");
sess.dcx().emit_fatal(FixedX18InvalidArch { arch: &sess.target.arch });
} else {
features.push("+reserve-x18".into());
}
features.push("+reserve-x18".into());
}
if diagnostics && let Some(f) = check_tied_features(sess, &featsmap) {