rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

commenting out special Eq implementation for now

Browse Source 
See the comments for details on why I'm leaving this code
in, though commented out.
This commit is contained in:
John Clements
2013-09-06 13:34:58 -07:00
parent 77c96d754e
commit acad9f35b3
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/libsyntax/ast.rs
View File

@@ -24,7 +24,7 @@ use extra::serialize::{Encodable, Decodable, Encoder, Decoder};
// table) and a SyntaxContext to track renaming and // table) and a SyntaxContext to track renaming and
// macro expansion per Flatt et al., "Macros // macro expansion per Flatt et al., "Macros
// That Work Together" // That Work Together"
#[deriving(Clone, IterBytes, ToStr)] #[deriving(Clone, Eq, IterBytes, ToStr)]
pub struct Ident { name: Name, ctxt: SyntaxContext } pub struct Ident { name: Name, ctxt: SyntaxContext }
impl Ident { impl Ident {
@@ -32,7 +32,17 @@ impl Ident {
pub fn new(name: Name) -> Ident { Ident {name: name, ctxt: EMPTY_CTXT}} pub fn new(name: Name) -> Ident { Ident {name: name, ctxt: EMPTY_CTXT}}
} }
impl Eq for Ident { // defining eq in this way is a way of guaranteeing that later stages of the
// compiler don't compare identifiers unhygienically. Unfortunately, some tests
// (specifically debuginfo in no-opt) want to do these comparisons, and that
// seems fine. If only I could find a nice way to statically ensure that
// the compiler "proper" never compares identifiers.... I'm leaving this
// code here (commented out) for potential use in debugging. Specifically, if
// there's a bug where "identifiers aren't matching", it may be because
// they should be compared using mtwt_resolve. In such a case, re-enabling this
// code (and disabling deriving(Eq) for Idents) could help to isolate the
// problem
/* impl Eq for Ident {
fn eq(&self, other: &Ident) -> bool { fn eq(&self, other: &Ident) -> bool {
if (self.ctxt == other.ctxt) { if (self.ctxt == other.ctxt) {
self.name == other.name self.name == other.name
@@ -44,6 +54,7 @@ impl Eq for Ident {
! self.eq(other) ! self.eq(other)
} }
} }
*/
/// A SyntaxContext represents a chain of macro-expandings /// A SyntaxContext represents a chain of macro-expandings
/// and renamings. Each macro expansion corresponds to /// and renamings. Each macro expansion corresponds to