rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Use inline(never) instead of cold

Browse Source 
inline(never) is better way to avoid optimizer to inline the function instead of cold.
This commit is contained in:
Howard Su
2020-09-03 06:31:21 +08:00
committed by GitHub
parent 80fc9b0ecb
commit a80d39041e
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
library/std/src/thread/local.rs
View File

@@ -424,10 +424,9 @@ pub mod fast {
// thread_local's, or it is being recursively initialized. // thread_local's, or it is being recursively initialized.
// //
// Macos: Inlining this function can cause two `tlv_get_addr` calls to // Macos: Inlining this function can cause two `tlv_get_addr` calls to
// be performed for every call to `Key::get`. The #[cold] hint makes // be performed for every call to `Key::get`.
// that less likely.
// LLVM issue: https://bugs.llvm.org/show_bug.cgi?id=41722 // LLVM issue: https://bugs.llvm.org/show_bug.cgi?id=41722
#[cold] #[inline(never)]
unsafe fn try_initialize<F: FnOnce() -> T>(&self, init: F) -> Option<&'static T> { unsafe fn try_initialize<F: FnOnce() -> T>(&self, init: F) -> Option<&'static T> {
if !mem::needs_drop::<T>() || self.try_register_dtor() { if !mem::needs_drop::<T>() || self.try_register_dtor() {
Some(self.inner.initialize(init)) Some(self.inner.initialize(init))