rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Simplify checking for all ones in int

Browse Source
This commit is contained in:
Yury Krivopalov
2017-10-15 10:21:56 +03:00
parent 033c99b1ba
commit a5d2bfebc4
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
clippy_lints/src/identity_op.rs
View File

@@ -58,18 +58,18 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for IdentityOp {
} }
} }
fn no_zeros(v: &ConstInt) -> bool { fn all_ones(v: &ConstInt) -> bool {
match *v { match *v {
ConstInt::I8(i) => i.count_zeros() == 0, ConstInt::I8(i) => i == !0,
ConstInt::I16(i) => i.count_zeros() == 0, ConstInt::I16(i) => i == !0,
ConstInt::I32(i) => i.count_zeros() == 0, ConstInt::I32(i) => i == !0,
ConstInt::I64(i) => i.count_zeros() == 0, ConstInt::I64(i) => i == !0,
ConstInt::I128(i) => i.count_zeros() == 0, ConstInt::I128(i) => i == !0,
ConstInt::U8(i) => i.count_zeros() == 0, ConstInt::U8(i) => i == !0,
ConstInt::U16(i) => i.count_zeros() == 0, ConstInt::U16(i) => i == !0,
ConstInt::U32(i) => i.count_zeros() == 0, ConstInt::U32(i) => i == !0,
ConstInt::U64(i) => i.count_zeros() == 0, ConstInt::U64(i) => i == !0,
ConstInt::U128(i) => i.count_zeros() == 0, ConstInt::U128(i) => i == !0,
_ => false _ => false
} }
} }
@@ -79,7 +79,7 @@ fn check(cx: &LateContext, e: &Expr, m: i8, span: Span, arg: Span) {
if let Some(Constant::Int(v)) = constant_simple(cx, e) { if let Some(Constant::Int(v)) = constant_simple(cx, e) {
if match m { if match m {
0 => v.to_u128_unchecked() == 0, 0 => v.to_u128_unchecked() == 0,
-1 => no_zeros(&v), -1 => all_ones(&v),
1 => v.to_u128_unchecked() == 1, 1 => v.to_u128_unchecked() == 1,
_ => unreachable!(), _ => unreachable!(),
} { } {