rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Change implementation of Ipv6Addr::is_unspecified and is_loopback from matches! to u128 comparison

Browse Source 
Done because `matches!` doesn't optimize well with array comparisons
This commit is contained in:
CDirkx
2020-09-01 21:05:26 +02:00
parent cd08deff3c
commit a43dd4f401
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
library/std/src/net/ip.rs
View File

@@ -1139,7 +1139,7 @@ impl Ipv6Addr {
#[rustc_const_unstable(feature = "const_ipv6", issue = "76205")] #[rustc_const_unstable(feature = "const_ipv6", issue = "76205")]
#[stable(since = "1.7.0", feature = "ip_17")] #[stable(since = "1.7.0", feature = "ip_17")]
pub const fn is_unspecified(&self) -> bool { pub const fn is_unspecified(&self) -> bool {
matches!(self.segments(), [0, 0, 0, 0, 0, 0, 0, 0]) u128::from_be_bytes(self.octets()) == u128::from_be_bytes(Ipv6Addr::UNSPECIFIED.octets())
} }
/// Returns [`true`] if this is a loopback address (::1). /// Returns [`true`] if this is a loopback address (::1).
@@ -1160,7 +1160,7 @@ impl Ipv6Addr {
#[rustc_const_unstable(feature = "const_ipv6", issue = "76205")] #[rustc_const_unstable(feature = "const_ipv6", issue = "76205")]
#[stable(since = "1.7.0", feature = "ip_17")] #[stable(since = "1.7.0", feature = "ip_17")]
pub const fn is_loopback(&self) -> bool { pub const fn is_loopback(&self) -> bool {
matches!(self.segments(), [0, 0, 0, 0, 0, 0, 0, 1]) u128::from_be_bytes(self.octets()) == u128::from_be_bytes(Ipv6Addr::LOCALHOST.octets())
} }
/// Returns [`true`] if the address appears to be globally routable. /// Returns [`true`] if the address appears to be globally routable.