rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

More useful fn detail in completion

Browse Source 
Detail should be rendered as shtort one line, just dumping fn header
there is not useful, despite the fact that TS does this.

The fact that this is a function should be indicated by the icon, the
same goes for pub/const/async etc qualitfiers

name is already present in the lable (and arg list should be a part of
that, as in idea)

But the return type is the small genuinerlly useful bit of info we can show here
This commit is contained in:
Aleksey Kladov
2021-01-22 18:59:22 +03:00
parent 02a17cdffc
commit a40f78f92a
9 changed files with 85 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
crates/completion/src/render.rs
View File

@@ -523,7 +523,7 @@ fn main() { let _: m::Spam = S$0 }
Function,
),
lookup: "main",
detail: "fn main()",
detail: "-> ()",
},
]
"#]],
@@ -552,7 +552,7 @@ fn main() { som$0 }
Function,
),
lookup: "main",
detail: "fn main()",
detail: "-> ()",
},
CompletionItem {
label: "something_deprecated()",
@@ -563,7 +563,7 @@ fn main() { som$0 }
Function,
),
lookup: "something_deprecated",
detail: "fn something_deprecated()",
detail: "-> ()",
deprecated: true,
},
CompletionItem {
@@ -575,7 +575,7 @@ fn main() { som$0 }
Function,
),
lookup: "something_else_deprecated",
detail: "fn something_else_deprecated()",
detail: "-> ()",
deprecated: true,
},
]
@@ -626,7 +626,7 @@ impl S {
insert: "bar()$0",
kind: Method,
lookup: "bar",
detail: "fn bar(self)",
detail: "-> ()",
documentation: Documentation(
"Method docs",
),
@@ -726,7 +726,7 @@ fn foo(s: S) { s.$0 }
insert: "the_method()$0",
kind: Method,
lookup: "the_method",
detail: "fn the_method(&self)",
detail: "-> ()",
},
]
"#]],