Address PR comments
- UPDATE - revert migration of logs - UPDATE - use derive on LinkRlibError enum - [Gardening] UPDATE - alphabetically sort fluent_messages - UPDATE - use PathBuf and unify both AddNativeLibrary to use Display (which is what PathBuf uses when conforming to IntoDiagnosticArg) - UPDATE - fluent messages sort after rebase
This commit is contained in:
@@ -91,13 +91,13 @@ pub fn get_linker<'a>(
|
||||
arg.push(format!("{}\\lib\\{}\\store", root_lib_path.display(), a));
|
||||
cmd.arg(&arg);
|
||||
} else {
|
||||
sess.emit_warning(errors::UnsupportedArch);
|
||||
warn!("arch is not supported");
|
||||
}
|
||||
} else {
|
||||
sess.emit_warning(errors::MsvcPathNotFound);
|
||||
warn!("MSVC root path lib location not found");
|
||||
}
|
||||
} else {
|
||||
sess.emit_warning(errors::LinkExeNotFound);
|
||||
warn!("link.exe not found");
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user