rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove redundant clone()

Browse Source
This commit is contained in:
Shotaro Yamada
2019-09-25 10:32:01 +09:00
parent 7e0fa71532
commit 9c45a9e586
14 changed files with 21 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/ra_hir/src/from_source.rs
View File

@@ -137,7 +137,7 @@ impl ModuleSource {
match &find_node_at_offset::<ast::Module>(parse.tree().syntax(), position.offset) {
Some(m) if !m.has_semi() => ModuleSource::Module(m.clone()),
_ => {
let source_file = parse.tree().to_owned();
let source_file = parse.tree();
ModuleSource::SourceFile(source_file)
}
}
@@ -149,15 +149,15 @@ impl ModuleSource {
child: &SyntaxNode,
) -> ModuleSource {
if let Some(m) = child.ancestors().filter_map(ast::Module::cast).find(|it| !it.has_semi()) {
ModuleSource::Module(m.clone())
ModuleSource::Module(m)
} else {
let source_file = db.parse(file_id).tree().to_owned();
let source_file = db.parse(file_id).tree();
ModuleSource::SourceFile(source_file)
}
}
pub fn from_file_id(db: &(impl DefDatabase + AstDatabase), file_id: FileId) -> ModuleSource {
let source_file = db.parse(file_id).tree().to_owned();
let source_file = db.parse(file_id).tree();
ModuleSource::SourceFile(source_file)
}
}