rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Concise mode for parameter hints

Browse Source 
This works around VS Code bug where it tries to cram everything in a
tiny popup, and brings experience closer to Intellij.
This commit is contained in:
Aleksey Kladov
2020-03-06 18:32:40 +01:00
parent 3ff170d658
commit 95a2755aa8
4 changed files with 27 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/rust-analyzer/src/main_loop/handlers.rs
View File

@@ -459,8 +459,12 @@ pub fn handle_signature_help(
let _p = profile("handle_signature_help");
let position = params.try_conv_with(&world)?;
if let Some(call_info) = world.analysis().call_info(position)? {
let active_parameter = call_info.active_parameter.map(|it| it as i64);
let sig_info = call_info.signature.conv();
let concise = !world.analysis().feature_flags().get("call-info.full");
let mut active_parameter = call_info.active_parameter.map(|it| it as i64);
if concise && call_info.signature.has_self_param {
active_parameter = active_parameter.map(|it| it.saturating_sub(1));
}
let sig_info = call_info.signature.conv_with(concise);
Ok(Some(req::SignatureHelp {
signatures: vec![sig_info],