rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Revert vita's c_char back to i8

Browse Source
This commit is contained in:
Aphek
2025-02-06 23:40:49 -03:00
parent 942db6782f
commit 93ef8089af
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
library/core/src/ffi/primitives.rs
View File

@@ -39,7 +39,6 @@ mod c_char_definition {
// These are the targets on which c_char is unsigned. Usually the // These are the targets on which c_char is unsigned. Usually the
// signedness is the same for all target_os values on a given architecture // signedness is the same for all target_os values on a given architecture
// but there are some exceptions (see isSignedCharDefault() in clang). // but there are some exceptions (see isSignedCharDefault() in clang).
//
// aarch64: // aarch64:
// Section 10 "Arm C and C++ language mappings" in Procedure Call Standard for the Arm® // Section 10 "Arm C and C++ language mappings" in Procedure Call Standard for the Arm®
// 64-bit Architecture (AArch64) says C/C++ char is unsigned byte. // 64-bit Architecture (AArch64) says C/C++ char is unsigned byte.
@@ -97,14 +96,19 @@ mod c_char_definition {
// are promoted to int as if from type signed char by default, unless the /J compilation // are promoted to int as if from type signed char by default, unless the /J compilation
// option is used." // option is used."
// https://learn.microsoft.com/en-us/cpp/cpp/fundamental-types-cpp?view=msvc-170#character-types // https://learn.microsoft.com/en-us/cpp/cpp/fundamental-types-cpp?view=msvc-170#character-types
// Vita:
// Chars are signed by default on the Vita, and VITASDK follows that convention.
// https://github.com/vitasdk/buildscripts/blob/09c533b771591ecde88864b6acad28ffb688dbd4/patches/gcc/0001-gcc-10.patch#L33-L34
//
// L4Re: // L4Re:
// The kernel builds with -funsigned-char on all targets (but useserspace follows the // The kernel builds with -funsigned-char on all targets (but userspace follows the
// architecture defaults). As we only have a target for userspace apps so there are no // architecture defaults). As we only have a target for userspace apps so there are no
// special cases for L4Re below. // special cases for L4Re below.
// https://github.com/rust-lang/rust/pull/132975#issuecomment-2484645240 // https://github.com/rust-lang/rust/pull/132975#issuecomment-2484645240
if #[cfg(all( if #[cfg(all(
not(windows), not(windows),
not(target_vendor = "apple"), not(target_vendor = "apple"),
not(target_os = "vita"),
any( any(
target_arch = "aarch64", target_arch = "aarch64",
target_arch = "arm", target_arch = "arm",