rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Add comment to remind filtering unsupported features when adding new ones

Browse Source
This commit is contained in:
WANG Rui
2025-04-29 22:15:11 +08:00
parent a2b3f11700
commit 74b55b4b86
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compiler/rustc_target/src/target_features.rs
View File

@@ -102,6 +102,9 @@ impl Stability {
// check whether they're named already elsewhere in rust // check whether they're named already elsewhere in rust
// e.g. in stdarch and whether the given name matches LLVM's // e.g. in stdarch and whether the given name matches LLVM's
// if it doesn't, to_llvm_feature in llvm_util in rustc_codegen_llvm needs to be adapted. // if it doesn't, to_llvm_feature in llvm_util in rustc_codegen_llvm needs to be adapted.
// Additionally, if the feature is not available in older version of LLVM supported by the current
// rust, the same function must be updated to filter out these features to avoid triggering
// warnings.
// //
// Also note that all target features listed here must be purely additive: for target_feature 1.1 to // Also note that all target features listed here must be purely additive: for target_feature 1.1 to
// be sound, we can never allow features like `+soft-float` (on x86) to be controlled on a // be sound, we can never allow features like `+soft-float` (on x86) to be controlled on a