more clippy::perf fixes

2022-09-03 22:57:22 +02:00
parent dec689432f
commit 6f4726541e
6 changed files with 11 additions and 19 deletions
--- a/compiler/rustc_resolve/src/diagnostics.rs
+++ b/compiler/rustc_resolve/src/diagnostics.rs
@@ -1393,7 +1393,7 @@ impl<'a> Resolver<'a> {

        // If only some candidates are accessible, take just them
        if !candidates.iter().all(|v: &ImportSuggestion| !v.accessible) {
-            candidates = candidates.into_iter().filter(|x| x.accessible).collect();
+            candidates.retain(|x| x.accessible)
        }

        candidates