Remove incorrect note from string_add_assign docs

The docs claim that `String::push_str` is better than `String::add` because `String::add` allocates a new string and drops the old one, but this is not true.  In fact, `add` reuses the existing string and grows it only if its capacity is exceeded, exactly like `push_str`.  Their performance is identical since `add` is just a wrapper for `push_str`:

```
    fn add(mut self, other: &str) -> String {
        self.push_str(other);
        self
    }
```

35bf1ae257/src/liballoc/string.rs (L1922-L1925)
This commit is contained in:
Matt Brubeck
2018-08-23 08:38:41 -07:00
committed by GitHub
parent e9c3d3d502
commit 6a0703664b

View File

@@ -9,8 +9,7 @@ use crate::utils::{get_parent_expr, is_allowed, match_type, paths, span_lint, sp
/// `let`!).
///
/// **Why is this bad?** It's not really bad, but some people think that the
/// `.push_str(_)` method is more readable. Also creates a new heap allocation and throws
/// away the old one.
/// `.push_str(_)` method is more readable.
///
/// **Known problems:** None.
///