rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove unnecessary Deref impl for Attribute.

Browse Source 
This kind of thing just makes the code harder to read.
This commit is contained in:
Nicholas Nethercote
2019-10-24 06:40:35 +11:00
parent e8b190ac4a
commit 69bc4aba78
17 changed files with 41 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/libsyntax_ext/proc_macro_harness.rs
View File

@@ -249,9 +249,9 @@ impl<'a> Visitor<'a> for CollectProcMacros<'a> {
for attr in &item.attrs {
if is_proc_macro_attr(&attr) {
if let Some(prev_attr) = found_attr {
let path_str = pprust::path_to_string(&attr.path);
let msg = if attr.path.segments[0].ident.name ==
prev_attr.path.segments[0].ident.name {
let path_str = pprust::path_to_string(&attr.item.path);
let msg = if attr.item.path.segments[0].ident.name ==
prev_attr.item.path.segments[0].ident.name {
format!(
"only one `#[{}]` attribute is allowed on any given function",
path_str,
@@ -261,7 +261,7 @@ impl<'a> Visitor<'a> for CollectProcMacros<'a> {
"`#[{}]` and `#[{}]` attributes cannot both be applied
to the same function",
path_str,
pprust::path_to_string(&prev_attr.path),
pprust::path_to_string(&prev_attr.item.path),
)
};
@@ -290,7 +290,7 @@ impl<'a> Visitor<'a> for CollectProcMacros<'a> {
if !is_fn {
let msg = format!(
"the `#[{}]` attribute may only be used on bare functions",
pprust::path_to_string(&attr.path),
pprust::path_to_string(&attr.item.path),
);
self.handler.span_err(attr.span, &msg);
@@ -304,7 +304,7 @@ impl<'a> Visitor<'a> for CollectProcMacros<'a> {
if !self.is_proc_macro_crate {
let msg = format!(
"the `#[{}]` attribute is only usable with crates of the `proc-macro` crate type",
pprust::path_to_string(&attr.path),
pprust::path_to_string(&attr.item.path),
);
self.handler.span_err(attr.span, &msg);