Rollup merge of #119704 - chenyukang:yukang-fix-let_underscore, r=Nilstrieb

Fix two variable binding issues in lint let_underscore

Fixes #119696
Fixes #119697
This commit is contained in:
Matthias Krüger
2024-01-09 00:19:35 +01:00
committed by GitHub
7 changed files with 110 additions and 2 deletions

View File

@@ -932,6 +932,7 @@ pub struct NonBindingLetSub {
pub suggestion: Span,
pub multi_suggestion_start: Span,
pub multi_suggestion_end: Span,
pub is_assign_desugar: bool,
}
impl AddToDiagnostic for NonBindingLetSub {
@@ -939,10 +940,11 @@ impl AddToDiagnostic for NonBindingLetSub {
where
F: Fn(&mut Diagnostic, SubdiagnosticMessage) -> SubdiagnosticMessage,
{
let prefix = if self.is_assign_desugar { "let " } else { "" };
diag.span_suggestion_verbose(
self.suggestion,
fluent::lint_non_binding_let_suggestion,
"_unused",
format!("{prefix}_unused"),
Applicability::MachineApplicable,
);
diag.multipart_suggestion(