rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Use unwrap instead of unwrap_unchecked

Browse Source 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
This commit is contained in:
Jiahao XU
2022-06-23 12:58:33 +10:00
parent d2211c9fdc
commit 516da4c93f
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
library/std/src/io/error.rs
View File

@@ -844,9 +844,13 @@ impl Error {
ErrorData::Custom(b) if b.error.is::<E>() => { ErrorData::Custom(b) if b.error.is::<E>() => {
let res = (*b).error.downcast::<E>(); let res = (*b).error.downcast::<E>();
// Safety: b.error.is::<E>() returns true, // downcast is a really trivial and is marked as inline, so
// which means that res must be Ok(e). // it's likely be inlined here.
Ok(unsafe { res.unwrap_unchecked() }) //
// And the compiler should be able to eliminate the branch
// that produces `Err` here since b.error.is::<E>()
// returns true.
Ok(res.unwrap())
} }
repr_data => Err(Self { repr: Repr::new(repr_data) }), repr_data => Err(Self { repr: Repr::new(repr_data) }),
} }