Be accurate on format! parse error expectations

This commit is contained in:
Esteban Küber
2019-09-01 15:09:05 -07:00
parent fba38ac27e
commit 4dec571ec6
5 changed files with 18 additions and 10 deletions

View File

@@ -138,15 +138,23 @@ fn parse_args<'a>(
}
let fmtstr = p.parse_expr()?;
let mut first = true;
let mut named = false;
while p.token != token::Eof {
if !p.eat(&token::Comma) {
let mut err = ecx.struct_span_err(p.token.span, "expected token: `,`");
err.span_label(p.token.span, "expected `,`");
p.maybe_annotate_with_ascription(&mut err, false);
return Err(err);
if first {
// After `format!(""` we always expect *only* a comma...
let mut err = ecx.struct_span_err(p.token.span, "expected token: `,`");
err.span_label(p.token.span, "expected `,`");
p.maybe_annotate_with_ascription(&mut err, false);
return Err(err);
} else {
// ...after that delegate to `expect` to also include the other expected tokens.
return Err(p.expect(&token::Comma).err().unwrap());
}
}
first = false;
if p.token == token::Eof {
break;
} // accept trailing commas