rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Loosen precision on i586 based on new tests

Browse Source
This commit is contained in:
Trevor Gross
2025-01-06 09:46:16 +00:00
parent 4b014bff40
commit 449d41a24f
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
library/compiler-builtins/libm/crates/libm-test/src/precision.rs
View File

@@ -106,7 +106,11 @@ pub fn default_ulp(ctx: &CheckCtx) -> u32 {
match ctx.fn_ident { match ctx.fn_ident {
Id::Asinh => ulp = 3, Id::Asinh => ulp = 3,
Id::Asinhf => ulp = 3, Id::Asinhf => ulp = 3,
Id::Exp10 | Id::Exp10f => ulp = 1_000_000,
Id::Exp2 | Id::Exp2f => ulp = 10_000_000,
Id::Fmaf => ulp = 1,
Id::Log1p | Id::Log1pf => ulp = 2, Id::Log1p | Id::Log1pf => ulp = 2,
Id::Rint => ulp = 100_000,
Id::Round => ulp = 1, Id::Round => ulp = 1,
Id::Tan => ulp = 2, Id::Tan => ulp = 2,
_ => (), _ => (),
@@ -271,15 +275,23 @@ impl MaybeOverride<(f64,)> for SpecialCase {
} }
if (ctx.fn_ident == Identifier::Ceil || ctx.fn_ident == Identifier::Floor) if (ctx.fn_ident == Identifier::Ceil || ctx.fn_ident == Identifier::Floor)
&& cfg!(x86_no_sse)
&& expected.eq_repr(F::NEG_ZERO) && expected.eq_repr(F::NEG_ZERO)
&& actual.eq_repr(F::ZERO) && actual.eq_repr(F::ZERO)
&& cfg!(x86_no_sse)
{ {
// FIXME: the x87 implementations do not keep the distinction between -0.0 and 0.0. // FIXME: the x87 implementations do not keep the distinction between -0.0 and 0.0.
// See https://github.com/rust-lang/libm/pull/404#issuecomment-2572399955 // See https://github.com/rust-lang/libm/pull/404#issuecomment-2572399955
return XFAIL; return XFAIL;
} }
if (ctx.fn_ident == Identifier::Exp10 || ctx.fn_ident == Identifier::Exp2)
&& cfg!(x86_no_sse)
{
// FIXME: i586 has very imprecise results with ULP > u32::MAX for these
// operations so we can't reasonably provide a limit.
return XFAIL;
}
maybe_check_nan_bits(actual, expected, ctx) maybe_check_nan_bits(actual, expected, ctx)
} }