rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Allow #![doc(test(attr(..)))] at every level

Browse Source
This commit is contained in:
Urgau
2025-05-05 22:50:40 +02:00
parent 041d95d4dc
commit 316e62a058
9 changed files with 147 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
compiler/rustc_passes/src/check_attr.rs
View File

@@ -1252,7 +1252,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
let bang_span = attr.span().lo() + BytePos(1);
let sugg = (attr.style() == AttrStyle::Outer
&& self.tcx.hir_get_parent_item(hir_id) == CRATE_OWNER_ID)
.then_some(errors::AttrCrateLevelSugg {
.then_some(errors::AttrCrateLevelOnlySugg {
attr: attr.span().with_lo(bang_span).with_hi(bang_span),
});
self.tcx.emit_node_span_lint(
@@ -1266,46 +1266,13 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
true
}
/// Checks that an attribute is used at module level. Returns `true` if valid.
fn check_attr_mod_level(
&self,
attr: &Attribute,
meta: &MetaItemInner,
hir_id: HirId,
target: Target,
) -> bool {
if target != Target::Mod {
// insert a bang between `#` and `[...`
let bang_span = attr.span().lo() + BytePos(1);
let sugg = (attr.style() == AttrStyle::Outer
&& self.tcx.hir_get_parent_item(hir_id) == CRATE_OWNER_ID)
.then_some(errors::AttrCrateLevelSugg {
attr: attr.span().with_lo(bang_span).with_hi(bang_span),
});
self.tcx.emit_node_span_lint(
INVALID_DOC_ATTRIBUTES,
hir_id,
meta.span(),
errors::AttrModLevelOnly { sugg },
);
return false;
}
true
}
/// Checks that `doc(test(...))` attribute contains only valid attributes and are at the right place.
fn check_test_attr(
&self,
attr: &Attribute,
meta: &MetaItemInner,
hir_id: HirId,
target: Target,
) {
fn check_test_attr(&self, attr: &Attribute, meta: &MetaItemInner, hir_id: HirId) {
if let Some(metas) = meta.meta_item_list() {
for i_meta in metas {
match (i_meta.name(), i_meta.meta_item()) {
(Some(sym::attr), _) => {
self.check_attr_mod_level(attr, meta, hir_id, target);
// Allowed everywhere like `#[doc]`
}
(Some(sym::no_crate_inject), _) => {
self.check_attr_crate_level(attr, meta, hir_id);
@@ -1396,7 +1363,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
}
Some(sym::test) => {
self.check_test_attr(attr, meta, hir_id, target);
self.check_test_attr(attr, meta, hir_id);
}
Some(