rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Remove MetaItemParser::{path,deconstruct}.

Browse Source 
They're equivalent, and `path` is unused, and `deconstruct` has only one
call site outside of `path`.
This commit is contained in:
Nicholas Nethercote
2025-05-20 11:57:21 +10:00
parent ea3b3fdcc1
commit 2cd2d24967
2 changed files with 7 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compiler/rustc_attr_parsing/src/context.rs
View File

@@ -260,7 +260,8 @@ impl<'sess> AttributeParser<'sess> {
// }
ast::AttrKind::Normal(n) => {
let parser = MetaItemParser::from_attr(n, self.dcx());
let (path, args) = parser.deconstruct();
let path = parser.path_without_args();
let args = parser.args();
let parts = path.segments().map(|i| i.name).collect::<Vec<_>>();
if let Some(accepts) = ATTRIBUTE_MAPPING.0.get(parts.as_slice()) {

19
compiler/rustc_attr_parsing/src/parser.rs
View File

@@ -253,7 +253,11 @@ impl<'a> MetaItemParser<'a> {
}
}
/// Gets just the path, without the args.
/// Gets just the path, without the args. Some examples:
///
/// - `#[rustfmt::skip]`: `rustfmt::skip` is a path
/// - `#[allow(clippy::complexity)]`: `clippy::complexity` is a path
/// - `#[inline]`: `inline` is a single segment path
pub fn path_without_args(&self) -> PathParser<'a> {
self.path.clone()
}
@@ -263,19 +267,6 @@ impl<'a> MetaItemParser<'a> {
&self.args
}
pub fn deconstruct(&self) -> (PathParser<'a>, &ArgParser<'a>) {
(self.path_without_args(), self.args())
}
/// Asserts that this MetaItem starts with a path. Some examples:
///
/// - `#[rustfmt::skip]`: `rustfmt::skip` is a path
/// - `#[allow(clippy::complexity)]`: `clippy::complexity` is a path
/// - `#[inline]`: `inline` is a single segment path
pub fn path(&self) -> (PathParser<'a>, &ArgParser<'a>) {
self.deconstruct()
}
/// Asserts that this MetaItem starts with a word, or single segment path.
///
/// Some examples: