rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

use correct edition when warning for unsafe attributes

Browse Source 
If an attribute is re-emitted by a macro, the incorrect edition was used to emit warnings for unsafe attributes
This commit is contained in:
Folkert de Vries
2025-06-09 21:55:17 +02:00
parent b6685d748f
commit 2c8257493d
3 changed files with 57 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
compiler/rustc_parse/src/validate_attr.rs
View File

@@ -180,9 +180,14 @@ pub fn check_attribute_safety(
let diag_span = attr_item.span();
// Attributes can be safe in earlier editions, and become unsafe in later ones.
//
// Use the span of the attribute's name to determine the edition: the span of the
// attribute as a whole may be inaccurate if it was emitted by a macro.
//
// See https://github.com/rust-lang/rust/issues/142182.
let emit_error = match unsafe_since {
None => true,
Some(unsafe_since) => attr.span.edition() >= unsafe_since,
Some(unsafe_since) => path_span.edition() >= unsafe_since,
};
if emit_error {