rust-lang/rust
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

rustdoc: Deduplicate lists of implementors

Browse Source 
Inlining caused implementors to show up multiple times.

cc #14584
This commit is contained in:
Alex Crichton
2014-06-01 11:30:53 -07:00
parent e1e8db7e4a
commit 287af7fa1a
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/librustdoc/html/render.rs
View File

@@ -108,6 +108,7 @@ pub enum ExternalLocation {
/// Metadata about an implementor of a trait. /// Metadata about an implementor of a trait.
pub struct Implementor { pub struct Implementor {
def_id: ast::DefId,
generics: clean::Generics, generics: clean::Generics,
trait_: clean::Type, trait_: clean::Type,
for_: clean::Type, for_: clean::Type,
@@ -531,6 +532,11 @@ fn write_shared(cx: &Context,
try!(write!(&mut f, r"implementors['{}'] = [", krate.name)); try!(write!(&mut f, r"implementors['{}'] = [", krate.name));
for imp in imps.iter() { for imp in imps.iter() {
// If the trait and implementation are in the same crate, then
// there's no need to emit information about it (there's inlining
// going on). If they're in different crates then the crate defining
// the trait will be interested in our implementation.
if imp.def_id.krate == did.krate { continue }
try!(write!(&mut f, r#""impl{} {} for {}","#, try!(write!(&mut f, r#""impl{} {} for {}","#,
imp.generics, imp.trait_, imp.for_)); imp.generics, imp.trait_, imp.for_));
} }
@@ -759,6 +765,7 @@ impl DocFolder for Cache {
Vec::new() Vec::new()
}); });
v.push(Implementor { v.push(Implementor {
def_id: item.def_id,
generics: i.generics.clone(), generics: i.generics.clone(),
trait_: i.trait_.get_ref().clone(), trait_: i.trait_.get_ref().clone(),
for_: i.for_.clone(), for_: i.for_.clone(),